From 40ff2ab62a4b1b4a5fad4cc8c102afb09135b9ca Mon Sep 17 00:00:00 2001 From: Sebastian Spaeth Date: Fri, 16 Apr 2010 08:38:48 +0200 Subject: [PATCH] notmuch-tag: don't sort messages before applying tag changes It's not neccessary to sort the results before we apply tags. Xapian contributor Olly Betts says that savings might be bigger with a cold file cache and (as unsorted implies really sorted by document id) a better cache locality when applying tags to messages. Signed-off-by: Sebastian Spaeth --- notmuch-tag.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/notmuch-tag.c b/notmuch-tag.c index 8b6f7dc0..fd54bc78 100644 --- a/notmuch-tag.c +++ b/notmuch-tag.c @@ -107,6 +107,9 @@ notmuch_tag_command (void *ctx, unused (int argc), unused (char *argv[])) return 1; } + /* tagging is not interested in any special sort order */ + notmuch_query_set_sort (query, NOTMUCH_SORT_UNSORTED); + for (messages = notmuch_query_search_messages (query); notmuch_messages_valid (messages) && !interrupted; notmuch_messages_move_to_next (messages)) -- 2.26.2