From 3f433cc70ce08a0fbf55eacaaafb4ccb755e7803 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Mon, 11 Apr 2016 21:33:02 +2100 Subject: [PATCH] Re: [PATCH v4 7/7] complete ghost-on-removal-when-shared-thread-exists --- 79/2c6585a2d63118cb6500ad19ea8d6d0de1c2a4 | 81 +++++++++++++++++++++++ 1 file changed, 81 insertions(+) create mode 100644 79/2c6585a2d63118cb6500ad19ea8d6d0de1c2a4 diff --git a/79/2c6585a2d63118cb6500ad19ea8d6d0de1c2a4 b/79/2c6585a2d63118cb6500ad19ea8d6d0de1c2a4 new file mode 100644 index 000000000..f88b8a15a --- /dev/null +++ b/79/2c6585a2d63118cb6500ad19ea8d6d0de1c2a4 @@ -0,0 +1,81 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 2C42B6DE02DD + for ; Sun, 10 Apr 2016 17:33:13 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.018 +X-Spam-Level: +X-Spam-Status: No, score=-0.018 tagged_above=-999 required=5 + tests=[AWL=-0.007, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id RJselYdEvfKx for ; + Sun, 10 Apr 2016 17:33:05 -0700 (PDT) +Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) + by arlo.cworth.org (Postfix) with ESMTPS id 6A3336DE02DB + for ; Sun, 10 Apr 2016 17:33:05 -0700 (PDT) +Received: from remotemail by fethera.tethera.net with local (Exim 4.84) + (envelope-from ) + id 1apPmz-0002BJ-JX; Sun, 10 Apr 2016 20:33:13 -0400 +Received: (nullmailer pid 6027 invoked by uid 1000); + Mon, 11 Apr 2016 00:33:02 -0000 +From: David Bremner +To: Daniel Kahn Gillmor , + Notmuch Mail +Subject: Re: [PATCH v4 7/7] complete + ghost-on-removal-when-shared-thread-exists +In-Reply-To: <1460166892-29721-7-git-send-email-dkg@fifthhorseman.net> +References: <1459445693-3900-1-git-send-email-dkg@fifthhorseman.net> + <1460166892-29721-1-git-send-email-dkg@fifthhorseman.net> + <1460166892-29721-7-git-send-email-dkg@fifthhorseman.net> +User-Agent: Notmuch/0.21+99~gd93d377 (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Sun, 10 Apr 2016 21:33:02 -0300 +Message-ID: <87r3ed6l35.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 11 Apr 2016 00:33:13 -0000 + +Daniel Kahn Gillmor writes: + +> To fully complete the ghost-on-removal-when-shared-thread-exists +> proposal, we need to clear all ghost messages when the last active +> message is removed from a thread. + +For me this patch breaks T530 as follows + +T530-upgrade: Testing database upgrade + FAIL ghost message retains thread ID + --- T530-upgrade.13.expected 2016-04-11 00:25:19.482196274 +0000 + +++ T530-upgrade.13.output 2016-04-11 00:25:19.482196274 +0000 + @@ -1 +1 @@ + -thread:000000000000001d + +thread:0000000000000011 +No new mail. +No new mail. Removed 1 message. + +I pushed my rebased version of the patches to + + https://git.notmuchmail.org/git?p=notmuch;a=shortlog;h=refs/heads/thread-fix + +in case the problem is some mistake on my part. + +d + + -- 2.26.2