From 3ceb28ecc339829d2a0473aa62d4ee8dd37e1fc5 Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Fri, 1 Aug 2014 22:59:13 +2000 Subject: [PATCH] [PATCH] lib: Fix slight misinformation in the database schema doc --- ae/e369ff5a4e127f6fa4a313fbb01757f5a11df2 | 104 ++++++++++++++++++++++ 1 file changed, 104 insertions(+) create mode 100644 ae/e369ff5a4e127f6fa4a313fbb01757f5a11df2 diff --git a/ae/e369ff5a4e127f6fa4a313fbb01757f5a11df2 b/ae/e369ff5a4e127f6fa4a313fbb01757f5a11df2 new file mode 100644 index 000000000..fff92e320 --- /dev/null +++ b/ae/e369ff5a4e127f6fa4a313fbb01757f5a11df2 @@ -0,0 +1,104 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1AC96431FB6 + for ; Thu, 31 Jul 2014 19:59:28 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id FUXW3mPl7VMe for ; + Thu, 31 Jul 2014 19:59:24 -0700 (PDT) +Received: from dmz-mailsec-scanner-2.mit.edu (dmz-mailsec-scanner-2.mit.edu + [18.9.25.13]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 22786431FAE + for ; Thu, 31 Jul 2014 19:59:23 -0700 (PDT) +X-AuditID: 1209190d-f79c06d000002f07-79-53db028bcfb1 +Received: from mailhub-auth-1.mit.edu ( [18.9.21.35]) + (using TLS with cipher AES256-SHA (256/256 bits)) + (Client did not present a certificate) + by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP + id 96.18.12039.B820BD35; Thu, 31 Jul 2014 22:59:23 -0400 (EDT) +Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) + by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id s712xKlk018265; + Thu, 31 Jul 2014 22:59:21 -0400 +Received: from drake.dyndns.org + (216-15-114-40.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com + [216.15.114.40]) (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id s712xJAp010496 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Thu, 31 Jul 2014 22:59:20 -0400 +Received: from amthrax by drake.dyndns.org with local (Exim 4.77) + (envelope-from ) + id 1XD33v-0004Wb-DM; Thu, 31 Jul 2014 22:59:19 -0400 +From: Austin Clements +To: notmuch@notmuchmail.org +Subject: [PATCH] lib: Fix slight misinformation in the database schema doc +Date: Thu, 31 Jul 2014 22:59:13 -0400 +Message-Id: <1406861953-17358-1-git-send-email-amdragon@mit.edu> +X-Mailer: git-send-email 2.0.0 +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFprFIsWRmVeSWpSXmKPExsUixCmqrNvNdDvYoPOPkMX1mzOZHRg9nq26 + xRzAGMVlk5Kak1mWWqRvl8CV8f/iVdaCJRwVy6acZ29gPMTWxcjJISFgIvH69gQoW0ziwr31 + QDYXh5DAbCaJX+8eskM4GxklJjQcYIZw7jBJ/J5zhh2kRUhgLqPE/tN1IDabgIbEtv3LGUFs + EQFpiZ13Z7N2MXJwMAuoSfzpUgEJCwt4SbQfP8UKYrMIqEo8fPaIBcTmFXCQ2H25EeoKOYmG + G5/YJjDyLmBkWMUom5JbpZubmJlTnJqsW5ycmJeXWqRrpJebWaKXmlK6iREcBJK8OxjfHVQ6 + xCjAwajEw+sQeitYiDWxrLgy9xCjJAeTkihv33+gEF9SfkplRmJxRnxRaU5q8SFGCQ5mJRHe + lx+AcrwpiZVVqUX5MClpDhYlcd631lbBQgLpiSWp2ampBalFMFkZDg4lCV5WYLALCRalpqdW + pGXmlCCkmTg4QYbzAA3nAanhLS5IzC3OTIfIn2JUlAIazQCUEABJZJTmwfXCovQVozjQK8K8 + jxiBqniAEQ7X/QpoMBPQ4Oe3roMMLklESEk1MHqvtbBpsw0Vsz30a+F3/r+TS6a4pif7v3td + /vnZGYltJRY3KvL9dBWN3qY9MvuQxKNt2PF8w/NNvkZ8eX2Hvghc7gxV/zZx+5MFXU+lrOQz + EqL7krN17sz7+6VGg3/+bPaMUoGH3AfPbpmvcG2nwNJ3l+9PaVuTwsC3YUJV5ILZq3LWzBD7 + s1CJpTgj0VCLuag4EQDQZxrIrQIAAA== +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 01 Aug 2014 02:59:28 -0000 + +The database schema documentation made it sound like each mail +document had exactly one on-disk message file, which hasn't been true +for a long time. +--- + lib/database.cc | 9 ++++++--- + 1 file changed, 6 insertions(+), 3 deletions(-) + +diff --git a/lib/database.cc b/lib/database.cc +index d90a924..c70ce63 100644 +--- a/lib/database.cc ++++ b/lib/database.cc +@@ -55,9 +55,12 @@ typedef struct { + * + * Mail document + * ------------- +- * A mail document is associated with a particular email message file +- * on disk. It is indexed with the following prefixed terms which the +- * database uses to construct threads, etc.: ++ * A mail document is associated with a particular email message. It ++ * is stored in one or more files on disk (though only one has its ++ * content indexed) and is uniquely identified by its "id" field ++ * (which is generally the message ID). It is indexed with the ++ * following prefixed terms which the database uses to construct ++ * threads, etc.: + * + * Single terms of given prefix: + * +-- +2.0.0 + -- 2.26.2