From 3cd6b806f4b8636b12bd24ef914bd7c19b58a2db Mon Sep 17 00:00:00 2001 From: stevenknight Date: Wed, 14 Apr 2004 17:14:07 +0000 Subject: [PATCH] More efficient check for environment equivalence when setting up Nodes. git-svn-id: http://scons.tigris.org/svn/scons/trunk@956 fdb21ef1-2011-0410-befe-b5e4ea1792b1 --- src/CHANGES.txt | 4 ++++ src/engine/SCons/Builder.py | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/CHANGES.txt b/src/CHANGES.txt index b5ed5001..f3e9a3df 100644 --- a/src/CHANGES.txt +++ b/src/CHANGES.txt @@ -79,6 +79,10 @@ RELEASE 0.96 - XXX of suffixes to be scanned by a given type of scanner, allowing these suffix lists to be easily added to or overridden. + - Speed up Node creation when calling a Builder by comparing whether two + Environments are the same object, not if their underlying dictionaries + are equivalent. + From Gary Oberbrunner: - Add a --debug=presub option to print actions prior to substitution. diff --git a/src/engine/SCons/Builder.py b/src/engine/SCons/Builder.py index 3d1fa873..5971056a 100644 --- a/src/engine/SCons/Builder.py +++ b/src/engine/SCons/Builder.py @@ -286,7 +286,7 @@ def _init_nodes(builder, env, overrides, tlist, slist): if t.side_effect: raise UserError, "Multiple ways to build the same target were specified for: %s" % str(t) if t.has_builder(): - if t.env != env: + if not t.env is env: t_contents = t.builder.action.get_contents(tlist, slist, t.env) contents = t.builder.action.get_contents(tlist, slist, env) -- 2.26.2