From 3cac5d63bbf9ce8229ab6e6339d27f8d62d8bf45 Mon Sep 17 00:00:00 2001 From: Marcus Brinkmann Date: Mon, 2 Sep 2002 12:17:51 +0000 Subject: [PATCH] 2002-09-02 Marcus Brinkmann * posix-io.c (_gpgme_io_select): Don't use a non-constant struct initializer. * version.c (_gpgme_get_program_version): Likewise. Reported by Dr. Stefan Dalibor . --- trunk/gpgme/ChangeLog | 6 ++++++ trunk/gpgme/posix-io.c | 4 +++- trunk/gpgme/version.c | 3 ++- 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/trunk/gpgme/ChangeLog b/trunk/gpgme/ChangeLog index abca388..105a713 100644 --- a/trunk/gpgme/ChangeLog +++ b/trunk/gpgme/ChangeLog @@ -1,3 +1,9 @@ +2002-09-02 Marcus Brinkmann + + * posix-io.c (_gpgme_io_select): Don't use a non-constant struct initializer. + * version.c (_gpgme_get_program_version): Likewise. + Reported by Dr. Stefan Dalibor . + 2002-09-02 Marcus Brinkmann * conversion.c (_gpgme_decode_c_string): Set DESTP before modifying DEST. diff --git a/trunk/gpgme/posix-io.c b/trunk/gpgme/posix-io.c index d0fd5f8..da7c106 100644 --- a/trunk/gpgme/posix-io.c +++ b/trunk/gpgme/posix-io.c @@ -306,12 +306,14 @@ _gpgme_io_select (struct io_select_fd_s *fds, size_t nfds, int nonblock) fd_set readfds; fd_set writefds; int any, i, max_fd, n, count; - struct timeval timeout = { nonblock ? 0 : 1, 0 }; /* Use a 1s timeout. */ + struct timeval timeout = { 1, 0 }; /* Use a 1s timeout. */ void *dbg_help = NULL; FD_ZERO (&readfds); FD_ZERO (&writefds); max_fd = 0; + if (nonblock) + timeout.tv_sec = 0; DEBUG_BEGIN (dbg_help, 3, "gpgme:select on [ "); any = 0; diff --git a/trunk/gpgme/version.c b/trunk/gpgme/version.c index 836a597..6fb0512 100644 --- a/trunk/gpgme/version.c +++ b/trunk/gpgme/version.c @@ -220,13 +220,14 @@ _gpgme_get_program_version (const char *const path) char *mark = NULL; int rp[2]; int nread; - char *argv[] = {(char *) path, "--version", 0}; + char *argv[] = {NULL /* path */, "--version", 0}; struct spawn_fd_item_s pfd[] = { {0, -1}, {-1, -1} }; struct spawn_fd_item_s cfd[] = { {-1, 1 /* STDOUT_FILENO */}, {-1, -1} }; int status; if (!path) return NULL; + argv[0] = (char *) path; if (_gpgme_io_pipe (rp, 1) < 0) return NULL; -- 2.26.2