From 3c1241f76489f2b814f665fe24fdee0d627e3f06 Mon Sep 17 00:00:00 2001 From: Michal Sojka Date: Sun, 2 Nov 2014 01:53:57 +0100 Subject: [PATCH] Re: [PATCH v6 6/7] cli: search: Add --output=count --- 0e/ce4b85cb1b98bb9c10b50a602318d1ec1d211e | 147 ++++++++++++++++++++++ 1 file changed, 147 insertions(+) create mode 100644 0e/ce4b85cb1b98bb9c10b50a602318d1ec1d211e diff --git a/0e/ce4b85cb1b98bb9c10b50a602318d1ec1d211e b/0e/ce4b85cb1b98bb9c10b50a602318d1ec1d211e new file mode 100644 index 000000000..f48d0381e --- /dev/null +++ b/0e/ce4b85cb1b98bb9c10b50a602318d1ec1d211e @@ -0,0 +1,147 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 706E4429E27 + for ; Sat, 1 Nov 2014 17:54:08 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Yk3LWgHdpr4N for ; + Sat, 1 Nov 2014 17:54:03 -0700 (PDT) +Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36]) + by olra.theworths.org (Postfix) with ESMTP id 5C125429E26 + for ; Sat, 1 Nov 2014 17:54:03 -0700 (PDT) +Received: from localhost (unknown [192.168.200.7]) + by max.feld.cvut.cz (Postfix) with ESMTP id B9A6E5CD288; + Sun, 2 Nov 2014 01:54:02 +0100 (CET) +X-Virus-Scanned: IMAP STYX AMAVIS +Received: from max.feld.cvut.cz ([192.168.200.1]) + by localhost (styx.feld.cvut.cz [192.168.200.7]) (amavisd-new, + port 10044) + with ESMTP id ZFiLrnN3PHBq; Sun, 2 Nov 2014 01:53:58 +0100 (CET) +Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34]) + by max.feld.cvut.cz (Postfix) with ESMTP id 7B1A85CD287; + Sun, 2 Nov 2014 01:53:57 +0100 (CET) +Received: from wsh by steelpick.2x.cz with local (Exim 4.84) + (envelope-from ) + id 1XkjQb-0008Cc-4b; Sun, 02 Nov 2014 01:53:57 +0100 +From: Michal Sojka +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH v6 6/7] cli: search: Add --output=count +In-Reply-To: <87r3xnu3dn.fsf@qmul.ac.uk> +References: <1414792441-29555-1-git-send-email-sojkam1@fel.cvut.cz> + <1414792441-29555-7-git-send-email-sojkam1@fel.cvut.cz> + <87r3xnu3dn.fsf@qmul.ac.uk> +User-Agent: Notmuch/0.18.2+157~ga00d359 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 02 Nov 2014 01:53:57 +0100 +Message-ID: <87bnoqbexm.fsf@steelpick.2x.cz> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 02 Nov 2014 00:54:08 -0000 + +On Sat, Nov 01 2014, Mark Walters wrote: +> On Fri, 31 Oct 2014, Michal Sojka wrote: +>> This output can be used with --output=recipients or --output=sender +>> and in addition to the addresses, it prints how many times was each +>> address encountered during search. +> +> Hi +> +> I have a couple comments on this patch. +> +>> --- +>> completion/notmuch-completion.bash | 2 +- +>> completion/notmuch-completion.zsh | 2 +- +>> doc/man1/notmuch-search.rst | 9 +++++-- +>> notmuch-search.c | 51 ++++++++++++++++++++++++++++++++------ +>> 4 files changed, 52 insertions(+), 12 deletions(-) +>> +>> diff --git a/completion/notmuch-completion.bash b/completion/notmuch-completion.bash +>> index cfbd389..39cd829 100644 +>> --- a/completion/notmuch-completion.bash +>> +++ b/completion/notmuch-completion.bash +>> @@ -294,7 +294,7 @@ _notmuch_search() +>> return +>> ;; +>> --output) +>> - COMPREPLY=( $( compgen -W "summary threads messages files tags sender recipients" -- "${cur}" ) ) +>> + COMPREPLY=( $( compgen -W "summary threads messages files tags sender recipients count" -- "${cur}" ) ) +>> return +>> ;; +>> --sort) +>> diff --git a/completion/notmuch-completion.zsh b/completion/notmuch-completion.zsh +>> index 3e52a00..d7e5a5e 100644 +>> --- a/completion/notmuch-completion.zsh +>> +++ b/completion/notmuch-completion.zsh +>> @@ -53,7 +53,7 @@ _notmuch_search() +>> '--max-threads=[display only the first x threads from the search results]:number of threads to show: ' \ +>> '--first=[omit the first x threads from the search results]:number of threads to omit: ' \ +>> '--sort=[sort results]:sorting:((newest-first\:"reverse chronological order" oldest-first\:"chronological order"))' \ +>> - '--output=[select what to output]:output:((summary threads messages files tags sender recipients))' +>> + '--output=[select what to output]:output:((summary threads messages files tags sender recipients count))' +>> } +>> +>> _notmuch() +>> diff --git a/doc/man1/notmuch-search.rst b/doc/man1/notmuch-search.rst +>> index 42f17e4..ec89200 100644 +>> --- a/doc/man1/notmuch-search.rst +>> +++ b/doc/man1/notmuch-search.rst +>> @@ -96,9 +96,14 @@ Supported options for **search** include +>> Like **sender** but for addresses from *To*, *Cc* and +>> *Bcc* headers. +>> +>> + **count** +>> + Can be used in combination with **sender** or +>> + **recipients** to print the count of how many times was +>> + the address encountered during search. +>> + +>> This option can be given multiple times to combine different +>> - outputs. Currently, this is only supported for **sender** and +>> - **recipients** outputs. +>> + outputs. Currently, this is only supported for **sender**, +>> + **recipients** and **count** outputs. +> +> It might be worth saying that the results will be slower if count is +> specified. + +I wrote something like this in +id:1414889400-30977-10-git-send-email-sojkam1@fel.cvut.cz. + +> +>> ``--sort=``\ (**newest-first**\ \|\ **oldest-first**) +> +> I think sort works as expected if count is not specified, but does not +> with count. + +Agreed. + +> Maybe count can be done by doing two passes? + +What do you mean by pass? + +> If it is difficult it might be sufficient to just document that sort +> has no effect. + +I'd do it this way :) + +Thanks, +-Michal -- 2.26.2