From 3ba26d048cd5a50792bd61bf9d01f66be5d4ad12 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Tue, 30 Apr 2013 18:23:01 +2100 Subject: [PATCH] Re: [PATCH] don't store temporary value returned from c_str() --- c4/6210297b053e7f441beec1c17b74fb565733b4 | 79 +++++++++++++++++++++++ 1 file changed, 79 insertions(+) create mode 100644 c4/6210297b053e7f441beec1c17b74fb565733b4 diff --git a/c4/6210297b053e7f441beec1c17b74fb565733b4 b/c4/6210297b053e7f441beec1c17b74fb565733b4 new file mode 100644 index 000000000..966331c07 --- /dev/null +++ b/c4/6210297b053e7f441beec1c17b74fb565733b4 @@ -0,0 +1,79 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 09AB9431FB6 + for ; Mon, 29 Apr 2013 14:23:22 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id B1JMfqdcmV6O for ; + Mon, 29 Apr 2013 14:23:17 -0700 (PDT) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 8D177431FAF + for ; Mon, 29 Apr 2013 14:23:17 -0700 (PDT) +Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net + ([156.34.82.78] helo=zancas.localnet) + by tesseract.cs.unb.ca with esmtpsa + (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) + (envelope-from ) + id 1UWvXP-00031x-6i; Mon, 29 Apr 2013 18:23:07 -0300 +Received: from bremner by zancas.localnet with local (Exim 4.80) + (envelope-from ) + id 1UWvXJ-0008IH-EY; Mon, 29 Apr 2013 18:23:01 -0300 +From: David Bremner +To: Vladimir Marek , Jani Nikula +Subject: Re: [PATCH] don't store temporary value returned from c_str() +In-Reply-To: <20130427160540.GB17459@vi64-x3-2e-prg06.cz.oracle.com> +References: <1366405933-17223-1-git-send-email-Vladimir.Marek@oracle.com> + <878v44qhop.fsf@nikula.org> + <20130427160540.GB17459@vi64-x3-2e-prg06.cz.oracle.com> +User-Agent: Notmuch/0.15.2+84~g12d5e4e (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-pc-linux-gnu) +Date: Mon, 29 Apr 2013 18:23:01 -0300 +Message-ID: <87y5c1uj4a.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-Spam_bar: - +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 29 Apr 2013 21:23:22 -0000 + +Vladimir Marek writes: + +>> It's okay to use the result of .c_str() as long as the string object +>> stays in scope, and none of the non-const member functions are +>> called. Here, I think the problem is that TermIterator's overloaded +>> operator*() returns a string object within the if block's scope, and it +>> goes immediately out of scope. You could check this by adding +> +> Right, I overlooked that TermIterator creates temporary string (if I +> understand you correctly). +> +>> fine too. +> +> I would prefer my change as it avoids creating another std::string. At +> least I think. + +Would you mind updating your commit message to reflect the best guesses +from this discussion? + +d -- 2.26.2