From 3a356b941e5e317ef4b117030bee862604aaa2c0 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Sat, 29 Nov 2014 20:09:45 +0100 Subject: [PATCH] Re: [Vagrant Cascadian] Bug#759646: notmuch-emacs: switching mode= to invalid value sends unencrypted mail --- da/b0ca3aec19e02a923d50b337429afcde85753a | 83 +++++++++++++++++++++++ 1 file changed, 83 insertions(+) create mode 100644 da/b0ca3aec19e02a923d50b337429afcde85753a diff --git a/da/b0ca3aec19e02a923d50b337429afcde85753a b/da/b0ca3aec19e02a923d50b337429afcde85753a new file mode 100644 index 000000000..a2ff45c72 --- /dev/null +++ b/da/b0ca3aec19e02a923d50b337429afcde85753a @@ -0,0 +1,83 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1353B431FC0 + for ; Sat, 29 Nov 2014 11:10:00 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id CjbJlexgWrJp for ; + Sat, 29 Nov 2014 11:09:51 -0800 (PST) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 8C2E7431FAE + for ; Sat, 29 Nov 2014 11:09:51 -0800 (PST) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1XunOw-00062J-HP; Sat, 29 Nov 2014 15:09:50 -0400 +Received: (nullmailer pid 19548 invoked by uid 1000); Sat, 29 Nov 2014 + 19:09:45 -0000 +From: David Bremner +To: notmuch@notmuchmail.org, 759646@bugs.debian.org +Subject: Re: [Vagrant Cascadian] Bug#759646: notmuch-emacs: switching mode= + to invalid value sends unencrypted mail +In-Reply-To: +References: <87lhq7npcw.fsf@maritornes.cs.unb.ca> <87k35q2zso.fsf@nikula.org> + <54055C53.40604@fifthhorseman.net> + + +User-Agent: Notmuch/0.19+2~g32855b9 (http://notmuchmail.org) Emacs/24.4.1 + (x86_64-pc-linux-gnu) +Date: Sat, 29 Nov 2014 20:09:45 +0100 +Message-ID: <87egsldds6.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 29 Nov 2014 19:10:00 -0000 + +David Edmondson writes: + +> On Tue, Sep 02 2014, Tomi Ollila wrote: +>> On Tue, Sep 02 2014, Daniel Kahn Gillmor wrote: +>> +>>> On 08/30/2014 03:37 AM, Jani Nikula wrote: +>>>> I'm inclined to think this is a bug in message-mode. +>>> +>>> I agree it's a bug in message-mode, not in notmuch itself. +>> +>> I think it might be here: +>> +>> http://bzr.savannah.gnu.org/lh/emacs/emacs-24/annotate/head:/lisp/gnus/mml.el#L258 +>> +>> (it takes time to load, please wait...) +>> +>> If cond does not match, then don't fail... +> +> This looks to have been fixed in emacs at the end of September 2014. + +Right, this fix was released in emacs 24.4 + +I'm a little torn what to do here. On the one hand the upstream change +fixes the bug as reported. On the other hand, if something corrupts the +#secure tag (e.g., by deleting a letter), then the message is still sent +un-uncrypted. + +d -- 2.26.2