From 384f122b7c6dd2b52cc6029afee16560c38850ae Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sun, 24 Jun 2007 21:13:11 +0200 Subject: [PATCH] Don't ignore a pack-refs write failure Without this, if the size of refs_file at that point is ever an exact multiple of BUFSIZ, then an EIO or ENOSPC error on the final write would not be diagnosed. It's not worth worrying about EPIPE here. Although theoretically possible that someone kill this process with a manual SIGPIPE, it's not at all likely. Signed-off-by: Jim Meyering Signed-off-by: Junio C Hamano --- builtin-pack-refs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/builtin-pack-refs.c b/builtin-pack-refs.c index 1952950c9..758499238 100644 --- a/builtin-pack-refs.c +++ b/builtin-pack-refs.c @@ -105,6 +105,8 @@ static int pack_refs(unsigned int flags) fprintf(cbdata.refs_file, "# pack-refs with: peeled \n"); for_each_ref(handle_one_ref, &cbdata); + if (ferror(cbdata.refs_file)) + die("failed to write ref-pack file"); if (fflush(cbdata.refs_file) || fsync(fd) || fclose(cbdata.refs_file)) die("failed to write ref-pack file (%s)", strerror(errno)); if (commit_lock_file(&packed) < 0) -- 2.26.2