From 37f5332e92798c7e880dd845135e51f0d048b660 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Sun, 6 Jul 2014 09:39:43 +2100 Subject: [PATCH] Re: [PATCH v2 01/10] lib: add return status to database close and destroy --- 31/168ac3edc9fb4911b62cba64e2cfa0b7bf3444 | 70 +++++++++++++++++++++++ 1 file changed, 70 insertions(+) create mode 100644 31/168ac3edc9fb4911b62cba64e2cfa0b7bf3444 diff --git a/31/168ac3edc9fb4911b62cba64e2cfa0b7bf3444 b/31/168ac3edc9fb4911b62cba64e2cfa0b7bf3444 new file mode 100644 index 000000000..d4cb93734 --- /dev/null +++ b/31/168ac3edc9fb4911b62cba64e2cfa0b7bf3444 @@ -0,0 +1,70 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 4C259431FB6 + for ; Sat, 5 Jul 2014 05:41:38 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id OC0R7HBQna0N for ; + Sat, 5 Jul 2014 05:41:30 -0700 (PDT) +Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net + [87.98.215.224]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id D177E431FAF + for ; Sat, 5 Jul 2014 05:41:29 -0700 (PDT) +Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim + 4.72) (envelope-from ) + id 1X3PG6-0005nN-SK; Sat, 05 Jul 2014 12:40:02 +0000 +Received: (nullmailer pid 23405 invoked by uid 1000); Sat, 05 Jul 2014 + 12:39:43 -0000 +From: David Bremner +To: Peter Wang , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 01/10] lib: add return status to database close and + destroy +In-Reply-To: <1397653165-15620-2-git-send-email-novalazy@gmail.com> +References: <1397653165-15620-1-git-send-email-novalazy@gmail.com> + <1397653165-15620-2-git-send-email-novalazy@gmail.com> +User-Agent: Notmuch/0.18.1+22~gbf82697 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sat, 05 Jul 2014 09:39:43 -0300 +Message-ID: <871tu0rncg.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 05 Jul 2014 12:41:38 -0000 + +Peter Wang writes: + +> From: Jani Nikula +> +> notmuch_database_close may fail in Xapian ->flush() or ->close(), so +> report the status. Similarly for notmuch_database_destroy which calls +> close. + +This patch looks OK, and it makes sense independent of what else +follows with respect to notmuch-insert. + +With respect so SONAME bumping, we might be able to get away with out it +here (although that could be un-portable or broken in a way I haven't +seen yet), but we can also delay that decision until closer to the next +release; I don't think it's as important to provide a stable ABI for +people building from git, and I'd prefer to batch ABI changes into one +SONAME bump. -- 2.26.2