From 371cbc78fbcc6f8279cff3c33c8193c447bb3b9f Mon Sep 17 00:00:00 2001
From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Sun, 20 Oct 2013 20:02:05 +0300
Subject: [PATCH] Re: [PATCH 1/3] database: Add notmuch_database_compact_close

---
 03/f9489dc94ab096ea670100fcc4b11a479b4403 | 72 +++++++++++++++++++++++
 1 file changed, 72 insertions(+)
 create mode 100644 03/f9489dc94ab096ea670100fcc4b11a479b4403

diff --git a/03/f9489dc94ab096ea670100fcc4b11a479b4403 b/03/f9489dc94ab096ea670100fcc4b11a479b4403
new file mode 100644
index 000000000..b2b081b55
--- /dev/null
+++ b/03/f9489dc94ab096ea670100fcc4b11a479b4403
@@ -0,0 +1,72 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id A1959431FC2
+	for <notmuch@notmuchmail.org>; Sun, 20 Oct 2013 10:02:22 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id 78swt2cGj9AT for <notmuch@notmuchmail.org>;
+	Sun, 20 Oct 2013 10:02:12 -0700 (PDT)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id BDE2E431FC0
+	for <notmuch@notmuchmail.org>; Sun, 20 Oct 2013 10:02:12 -0700 (PDT)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id ECB5E10007D;
+	Sun, 20 Oct 2013 20:02:05 +0300 (EEST)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: Ben Gamari <bgamari.foss@gmail.com>, notmuch@notmuchmail.org
+Subject: Re: [PATCH 1/3] database: Add notmuch_database_compact_close
+In-Reply-To: <m2ob6xw4bw.fsf@guru.guru-group.fi>
+References: <1380745848-4972-1-git-send-email-bgamari.foss@gmail.com>
+	<1380745848-4972-2-git-send-email-bgamari.foss@gmail.com>
+	<m2ob6xw4bw.fsf@guru.guru-group.fi>
+User-Agent: Notmuch/0.16+112~g46b74be (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Sun, 20 Oct 2013 20:02:05 +0300
+Message-ID: <m2fvrv7u5u.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sun, 20 Oct 2013 17:02:22 -0000
+
+On Thu, Oct 10 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:
+
+>
+> another, small change:
+>
+>       case "${xapian_version}" in
+> -         0.*|1.[01].*|1.2.[0-5])
+> +         0.*|1.[01].*|1.2.[0-5]|1.2.[0-5][^0-9]*)
+>               printf "No (only available with Xapian > 1.2.6).\n" ;;
+
+Forget the above suggestion, as mentioned below this would not work in
+dash. I presume attempting to compile compaction support will fail in 
+case such support is not there. If we ever encounter such a bug report
+let's revisit this then...
+
+> someone might do version like 1.2.4-abc but probably not 1.2.04 (nor 1.2a.4)
+>
+> (side note: case $x in [^...]) works with bash (and ksh&zsh, but not with dash)
+
+Tomi
-- 
2.26.2