From 36b55411580ad23db90bb0f4d8f10991e73cbd85 Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Thu, 30 Jan 2014 07:34:24 +0100 Subject: [PATCH] Re: [PATCH 0/5] lib: make folder: prefix literal --- 5e/24f38741504cf414842142cfdfb13bca57e86b | 112 ++++++++++++++++++++++ 1 file changed, 112 insertions(+) create mode 100644 5e/24f38741504cf414842142cfdfb13bca57e86b diff --git a/5e/24f38741504cf414842142cfdfb13bca57e86b b/5e/24f38741504cf414842142cfdfb13bca57e86b new file mode 100644 index 000000000..57ca354a0 --- /dev/null +++ b/5e/24f38741504cf414842142cfdfb13bca57e86b @@ -0,0 +1,112 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1FD96431FBF + for ; Wed, 29 Jan 2014 22:34:53 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id a2tvyL4Vpd3F for ; + Wed, 29 Jan 2014 22:34:39 -0800 (PST) +Received: from mail-qa0-f41.google.com (mail-qa0-f41.google.com + [209.85.216.41]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 722A4431FBD + for ; Wed, 29 Jan 2014 22:34:37 -0800 (PST) +Received: by mail-qa0-f41.google.com with SMTP id w8so3871304qac.14 + for ; Wed, 29 Jan 2014 22:34:35 -0800 (PST) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:cc:subject:in-reply-to:references + :user-agent:date:message-id:mime-version:content-type; + bh=mKLDJf5am2UQIN8GPyuRTMU3a5M7g3shughbnNDJ0dc=; + b=Zpc3pYAUu5f21zEGMOph7mqd+/HyQr6359ry66e0rjoqSbGD38OtfUBCWv8JoU7YXP + qCpcNHlv/zMYBAhOBKimG8ieN3Ri7Rutj3mrPTx1Z0k0TJgETXvRFfjZLSYQqtR+T0lJ + 01ptuIZWbmQhwHivcFy03Tp48txwAunX/8fYtgZTAV4N0BOfggDrLWi9E6deUYUqQIwd + RW6rYrICMhExlZY8ux3lH/9HtB/qns4+fCGdOotYea8rzgyXFeHaYOKk5phMQ/gn1mjv + zquS3+ww8MWzwX29032yhYLt5CmMz+MnJlDkM9nvNpyyYNn1HLURhsqvc1DoxU47q1t/ + bb7A== +X-Gm-Message-State: + ALoCoQlAPnLUG4AsJgLdI4lOlw/6hpJoyTLrgRSxFqufPeVaEiMZoxVs+DJoVXf3vRCRErxO02gj +X-Received: by 10.229.71.69 with SMTP id g5mr19064127qcj.6.1391063674892; + Wed, 29 Jan 2014 22:34:34 -0800 (PST) +Received: from localhost ([2001:4b98:dc0:43:216:3eff:fe1b:25f3]) + by mx.google.com with ESMTPSA id g6sm14269106qag.17.2014.01.29.22.34.33 + for + (version=TLSv1.1 cipher=RC4-SHA bits=128/128); + Wed, 29 Jan 2014 22:34:34 -0800 (PST) +From: Jani Nikula +To: Carl Worth , Austin Clements +Subject: Re: [PATCH 0/5] lib: make folder: prefix literal +In-Reply-To: <87bnyuqw60.fsf@yoom.home.cworth.org> +References: + <87y525m649.fsf@awakening.csail.mit.edu> + <87r47wfltb.fsf@nikula.org> <87iot8f4vg.fsf@nikula.org> + <874n4rvcvo.fsf@yoom.home.cworth.org> <874n4mfw1x.fsf@nikula.org> + <87k3dir3ci.fsf@yoom.home.cworth.org> + <20140129204608.GE4375@mit.edu> + <87bnyuqw60.fsf@yoom.home.cworth.org> +User-Agent: Notmuch/0.17~rc2+18~gab1d8e8 (http://notmuchmail.org) Emacs/23.2.1 + (x86_64-pc-linux-gnu) +Date: Thu, 30 Jan 2014 07:34:24 +0100 +Message-ID: <87a9eeou4v.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 30 Jan 2014 06:34:55 -0000 + +On Wed, 29 Jan 2014, Carl Worth wrote: +> Austin Clements writes: +>> I think you're assuming we have much more control over this than we +>> do. +> +> To be fair, I only started discussing my proposal for '^' and '$' in +> response to Jani's proposal with special semantics for trailing '/' and +> "/.". + +I only chose those to avoid any collisions with actual file names, +without much further thought. I'm not a fan of rsync's trailing '/' +semantics either. The main point was to demonstrate that if folder: were +a boolean prefix, it would be possible to index folder terms in a way +that would address the issues with the current folder: prefix. + +I don't have good counter-proposals now, but an *example* is having +"sub-prefixes" like "folder:recursive::foo" or "folder:maildir::bar", +where the former would match anything under foo and the latter would +match anything in bar/new and bar/cur. These "recursive::" and +"maildir::" prefixes would be just part of the indexed boolean terms. + +> Support for any of this magic syntax would require a custom query +> parser, yes. +> +> Austin, haven't you been proposing a custom query parser for ages? Where +> does that work stand now? + +That is the unicorn... many of the query improvements I have in mind +depend on a custom query parser. So I'd like to have that. And a +pony. But in the mean time, I'm left wondering whether I should pursue +folder: as a boolean prefix, or try to figure out if there are +improvements to be made as a probabilistic prefix, or just put this work +on hold. With the db upgrade and upgrade tests, it's not exactly a +trivial amount of work. + +BR, +Jani. -- 2.26.2