From 34ce6fb8b4c1a897d176834927fce0f6a9e8ad77 Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Mon, 6 Oct 2014 19:29:56 +2000 Subject: [PATCH] Re: [PATCH 08/11] lib: Implement upgrade to ghost messages feature --- 2e/8fc0f6b19a7da36c9b9a10e7528ad8dc22aacd | 75 +++++++++++++++++++++++ 1 file changed, 75 insertions(+) create mode 100644 2e/8fc0f6b19a7da36c9b9a10e7528ad8dc22aacd diff --git a/2e/8fc0f6b19a7da36c9b9a10e7528ad8dc22aacd b/2e/8fc0f6b19a7da36c9b9a10e7528ad8dc22aacd new file mode 100644 index 000000000..737f0e7d0 --- /dev/null +++ b/2e/8fc0f6b19a7da36c9b9a10e7528ad8dc22aacd @@ -0,0 +1,75 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id EE8B4431FB6 + for ; Sun, 5 Oct 2014 16:30:02 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id C8gXqMJ-ltjL for ; + Sun, 5 Oct 2014 16:29:57 -0700 (PDT) +Received: from outgoing.csail.mit.edu (outgoing.csail.mit.edu [128.30.2.149]) + by olra.theworths.org (Postfix) with ESMTP id 5BC1B431FAE + for ; Sun, 5 Oct 2014 16:29:57 -0700 (PDT) +Received: from [104.131.20.129] (helo=awakeningjr) + by outgoing.csail.mit.edu with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) + (Exim 4.72) (envelope-from ) + id 1XavFU-0000VZ-Vw; Sun, 05 Oct 2014 19:29:57 -0400 +Received: from amthrax by awakeningjr with local (Exim 4.84) + (envelope-from ) + id 1XavFU-0004fU-N1; Sun, 05 Oct 2014 19:29:56 -0400 +Date: Sun, 5 Oct 2014 19:29:56 -0400 +From: Austin Clements +To: David Bremner +Subject: Re: [PATCH 08/11] lib: Implement upgrade to ghost messages feature +Message-ID: <20141005232956.GD7970@csail.mit.edu> +References: <1412345958-8278-1-git-send-email-aclements@csail.mit.edu> + <1412345958-8278-9-git-send-email-aclements@csail.mit.edu> + <87d2a6q4hf.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <87d2a6q4hf.fsf@maritornes.cs.unb.ca> +User-Agent: Mutt/1.5.23 (2014-03-12) +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 05 Oct 2014 23:30:03 -0000 + +Quoth David Bremner on Oct 05 at 10:56 am: +> Austin Clements writes: +> > + if (new_features & NOTMUCH_FEATURE_GHOSTS) { +> > + t_end = db->metadata_keys_end ("thread_id_"); +> > + for (t = db->metadata_keys_begin ("thread_id_"); t != t_end; ++t) +> > + ++total; +> > + } +> +> It would be nice to have the comment below, or something like it, for +> the loop above. + + /* The ghost message upgrade converts all thread_id_* + * metadata values into ghost message documents. */ +sound good? + +> > + /* Perform metadata upgrades. */ +> > + +> > + /* Prior to NOTMUCH_FEATURE_GHOSTS, thread IDs for missing +> > + * messages were stored as database metadata. Change these to +> > + * ghost messages. +> > + */ -- 2.26.2