From 33108a3bf914be0d90c312a1d18e5bba53a41999 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Fri, 6 Sep 2013 22:22:42 +2100 Subject: [PATCH] Re: segfault with xapian 1.3.1 --- 67/0457bee51b40afdad612396e6f92a085a5227c | 74 +++++++++++++++++++++++ 1 file changed, 74 insertions(+) create mode 100644 67/0457bee51b40afdad612396e6f92a085a5227c diff --git a/67/0457bee51b40afdad612396e6f92a085a5227c b/67/0457bee51b40afdad612396e6f92a085a5227c new file mode 100644 index 000000000..7b54220e5 --- /dev/null +++ b/67/0457bee51b40afdad612396e6f92a085a5227c @@ -0,0 +1,74 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 401CE431E82 + for ; Thu, 5 Sep 2013 18:22:54 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id avykhd6HQh2y for ; + Thu, 5 Sep 2013 18:22:50 -0700 (PDT) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id F09ED431E62 + for ; Thu, 5 Sep 2013 18:22:49 -0700 (PDT) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1VHkl5-0001xc-91; Thu, 05 Sep 2013 22:22:47 -0300 +Received: (nullmailer pid 4013 invoked by uid 1000); Fri, 06 Sep 2013 + 01:22:42 -0000 +From: David Bremner +To: "Jason A. Donenfeld" , notmuch ML + +Subject: Re: segfault with xapian 1.3.1 +In-Reply-To: <87txhypzvz.fsf@zancas.localnet> +References: + + <87txhypzvz.fsf@zancas.localnet> +User-Agent: Notmuch/0.16+37~g9701e9c (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Thu, 05 Sep 2013 22:22:42 -0300 +Message-ID: <87r4d2pwv1.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +Cc: Olly Betts +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 06 Sep 2013 01:22:54 -0000 + +David Bremner writes: + +> +> I managed to duplicate this problem on Debian testing by rebuilding +> Olly's packages (https://launchpad.net/~ojwb/+archive/xapian-1.3) for +> sid and running the following script in the ./test subdirectory + +Olly wrote on IRC: + +> bremner: ok, 1.2 explicitly no-oped skip_to() on an iterator at_end on +> trunk that code has been rewritten without that explicit check, and +> the iterator internals are NULL then i think restoring the check is +> reasonable, though I'm not sure if we actually promise that's defined +> behaviour if you want to work with 1.3.1, then checking against the +> end iterator before calling skip_to() will work for any version + +So, now we know what to fix. + +d -- 2.26.2