From 32a28a031addad8585b08e6407755c833dba3441 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Tue, 22 Oct 2013 09:03:46 +0300 Subject: [PATCH] Re: [PATCH] perf: Clean corpus and caches in distclean, not clean --- 59/e6288f969427e54293f1eabf78da9b9b967832 | 84 +++++++++++++++++++++++ 1 file changed, 84 insertions(+) create mode 100644 59/e6288f969427e54293f1eabf78da9b9b967832 diff --git a/59/e6288f969427e54293f1eabf78da9b9b967832 b/59/e6288f969427e54293f1eabf78da9b9b967832 new file mode 100644 index 000000000..46732feac --- /dev/null +++ b/59/e6288f969427e54293f1eabf78da9b9b967832 @@ -0,0 +1,84 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 4FB8D431FC7 + for ; Mon, 21 Oct 2013 23:03:59 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Y9CDBSj2REk5 for ; + Mon, 21 Oct 2013 23:03:53 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 46E83431FAF + for ; Mon, 21 Oct 2013 23:03:53 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 01424100217; + Tue, 22 Oct 2013 09:03:46 +0300 (EEST) +From: Tomi Ollila +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH] perf: Clean corpus and caches in distclean, not clean +In-Reply-To: <1382403338-9200-1-git-send-email-amdragon@mit.edu> +References: <1382403338-9200-1-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.16+112~g46b74be (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 22 Oct 2013 06:03:59 -0000 + +On Tue, Oct 22 2013, Austin Clements wrote: + +> Previously, we cleaned the downloaded performance corpus and the +> cached indexes on 'make clean'. This seems heavy-handed, since these +> take a long time to download, unpack, and index. They also aren't +> make targets to begin with. Move cleaning these to 'make distclean'. +> This isn't exactly the right meaning of "distclean", but it's closer. +> --- + +Good point(s). +1 + +Tomi + +> performance-test/Makefile.local | 3 ++- +> 1 file changed, 2 insertions(+), 1 deletion(-) +> +> diff --git a/performance-test/Makefile.local b/performance-test/Makefile.local +> index e47219a..d97e56d 100644 +> --- a/performance-test/Makefile.local +> +++ b/performance-test/Makefile.local +> @@ -39,4 +39,5 @@ $(TXZFILE): +> download-corpus: +> wget -O ${TXZFILE} ${DEFAULT_URL} +> +> -CLEAN := $(CLEAN) $(dir)/tmp.* $(dir)/log.* $(dir)/corpus $(dir)/notmuch.cache.* +> +CLEAN := $(CLEAN) $(dir)/tmp.* $(dir)/log.* +> +DISTCLEAN := $(dir)/corpus $(dir)/notmuch.cache.* +> -- +> 1.8.4.rc3 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2