From 323d2e7dd943782900492a619a64631793754fc7 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Mon, 31 Aug 2015 13:52:46 +0300 Subject: [PATCH] Re: [RFC PATCH 5/5] cli: add support for deduplicating based on case insensitive address --- 19/c4b4487b887b6fe90b0e8b36ac80ac817efd8c | 80 +++++++++++++++++++++++ 1 file changed, 80 insertions(+) create mode 100644 19/c4b4487b887b6fe90b0e8b36ac80ac817efd8c diff --git a/19/c4b4487b887b6fe90b0e8b36ac80ac817efd8c b/19/c4b4487b887b6fe90b0e8b36ac80ac817efd8c new file mode 100644 index 000000000..4bd4e5a5f --- /dev/null +++ b/19/c4b4487b887b6fe90b0e8b36ac80ac817efd8c @@ -0,0 +1,80 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id AD1156DE00CB + for ; Mon, 31 Aug 2015 03:54:21 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 1.202 +X-Spam-Level: * +X-Spam-Status: No, score=1.202 tagged_above=-999 required=5 tests=[AWL=-0.194, + SPF_NEUTRAL=0.652, URIBL_SBL=0.644, URIBL_SBL_A=0.1] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id bLQukTsoyXeK for ; + Mon, 31 Aug 2015 03:54:19 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by arlo.cworth.org (Postfix) with ESMTP id 44A846DE005F + for ; Mon, 31 Aug 2015 03:54:18 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 15EC210005A; + Mon, 31 Aug 2015 13:52:47 +0300 (EEST) +From: Tomi Ollila +To: David Bremner , Jani Nikula , + notmuch@notmuchmail.org +Subject: Re: [RFC PATCH 5/5] cli: add support for deduplicating based on case + insensitive address +In-Reply-To: <874mjht1y6.fsf@maritornes.cs.unb.ca> +References: + + <874mjht1y6.fsf@maritornes.cs.unb.ca> +User-Agent: Notmuch/0.20.2+68~g0c35549 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 31 Aug 2015 10:54:21 -0000 + +On Sun, Aug 30 2015, David Bremner wrote: + +> Jani Nikula writes: +> +>> Consider all variants of an email address as one, and print the most +>> common variant. +> +> Other than the quibbles already mentioned, the series looks ok to +> me. For production it should have one or two tests I guess. Oh, and man +> page updates. But you knew that I guess. +> +> I can live with the current argument syntax, but since a certain a mount +> of bikeshedding is expected, here is an alternative suggestion +> +> --deduplication={none|mailbox|address} + +(is s/deduplicate/deduplication/ intended or accidental change?) + +Is this complete alternative to --deduplicate={no|yes|address}, respectively? + +If it is it looks somewhat better to me (provided that it is accurate) +anyway, the user command line interface looks good to me. + + + +Tomi -- 2.26.2