From 31dad20a7a9158cc0e7b071e4dc840aa1f79c02e Mon Sep 17 00:00:00 2001 From: David Bremner Date: Wed, 24 Sep 2014 22:13:31 +0200 Subject: [PATCH] Re: [PATCH] lib: Simplify close and codify aborting atomic section --- 97/1c4232a11900c3d68ba316065c3b38ff01535e | 77 +++++++++++++++++++++++ 1 file changed, 77 insertions(+) create mode 100644 97/1c4232a11900c3d68ba316065c3b38ff01535e diff --git a/97/1c4232a11900c3d68ba316065c3b38ff01535e b/97/1c4232a11900c3d68ba316065c3b38ff01535e new file mode 100644 index 000000000..2416f70a6 --- /dev/null +++ b/97/1c4232a11900c3d68ba316065c3b38ff01535e @@ -0,0 +1,77 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 20185431FAF + for ; Wed, 24 Sep 2014 13:13:42 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id K9Qn-FsvJc4z for ; + Wed, 24 Sep 2014 13:13:38 -0700 (PDT) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 442E8431FB6 + for ; Wed, 24 Sep 2014 13:13:38 -0700 (PDT) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1XWswS-0001y7-Kk; Wed, 24 Sep 2014 17:13:36 -0300 +Received: (nullmailer pid 6974 invoked by uid 1000); Wed, 24 Sep 2014 + 20:13:31 -0000 +From: David Bremner +To: "W. Trevor King" +Subject: Re: [PATCH] lib: Simplify close and codify aborting atomic section +In-Reply-To: <20140924194413.GC20130@odin.tremily.us> +References: <1411400615-20934-1-git-send-email-amdragon@mit.edu> + <20140922165954.GI20827@odin.tremily.us> + <20140922185050.GB7970@csail.mit.edu> + <20140922190022.GO20827@odin.tremily.us> + <87iokc28mg.fsf@maritornes.cs.unb.ca> + <20140924181844.GB20130@odin.tremily.us> + <87d2ak253z.fsf@maritornes.cs.unb.ca> + <20140924194413.GC20130@odin.tremily.us> +User-Agent: Notmuch/0.18.1+98~gae27403 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Wed, 24 Sep 2014 22:13:31 +0200 +Message-ID: <87a95o22vo.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 24 Sep 2014 20:13:42 -0000 + +"W. Trevor King" writes: + +> On Wed, Sep 24, 2014 at 09:25:20PM +0200, David Bremner wrote: +>> I think the fact that you have to close the notmuch database (when +>> not using begin/end atomic) to get a commit is surprising for many +>> people, so it would be nice to make that clearer somehow. +> +> It looks like Xapian is GPLv2+, so we should just be able to +> copy/paste/edit the line I quoted from the Xapian docs. +> +> Cheers, +> Trevor + +I think it would be better to write our own, not because of licensing +issues, but because the user of the notmuch API won't know what a xapian +commit is. + +d -- 2.26.2