From 3048d90063da6df5f07568d537f45ae2a716e22c Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Mon, 10 Jun 2013 18:30:18 +0300 Subject: [PATCH] Re: [PATCH v2 0/7] cli: better tooling support for duplicate messages --- 88/d4653d19ee3a6d8d64fb27da25cc44f33e1705 | 98 +++++++++++++++++++++++ 1 file changed, 98 insertions(+) create mode 100644 88/d4653d19ee3a6d8d64fb27da25cc44f33e1705 diff --git a/88/d4653d19ee3a6d8d64fb27da25cc44f33e1705 b/88/d4653d19ee3a6d8d64fb27da25cc44f33e1705 new file mode 100644 index 000000000..432f71a47 --- /dev/null +++ b/88/d4653d19ee3a6d8d64fb27da25cc44f33e1705 @@ -0,0 +1,98 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 06589431FB6 + for ; Mon, 10 Jun 2013 08:30:28 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id AhEtPYSuMFAL for ; + Mon, 10 Jun 2013 08:30:20 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 68258431FAE + for ; Mon, 10 Jun 2013 08:30:20 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 959A9100052; + Mon, 10 Jun 2013 18:30:18 +0300 (EEST) +From: Tomi Ollila +To: Jani Nikula , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 0/7] cli: better tooling support for duplicate messages +In-Reply-To: +References: +User-Agent: Notmuch/0.15.2+181~gfb53171 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 10 Jun 2013 15:30:28 -0000 + +On Sun, Jun 09 2013, Jani Nikula wrote: + +> v2 of id:cover.1368467532.git.jani@nikula.org +> +> The only change is switching to 1-based indexing for --duplicate=N +> option. + +The code looks good to me. Mark's comment about showing duplicate file +from another folder than mentioned in query string could be tackled +in manual somehow. +Also, when you make next version fix the commit message in +id:61ed86f221d65b4dba438cbc2b4c5b77a484a534.1370775663.git.jani@nikula.org +to mention 1-based. + +> Jani. + +Tomi + +BTW: can we track on which machine you're working on by looking +Message-Id:s >;) + +> +> +> Jani Nikula (7): +> cli: add --duplicate=N option to notmuch search +> test: test notmuch search --duplicate=N +> man: document notmuch search --duplicate=N +> cli: add --output=files option to notmuch count +> test: test notmuch count --output=files +> man: document notmuch count --output=files +> NEWS: cli options for improved duplicate message handling +> +> NEWS | 12 +++++++++ +> man/man1/notmuch-count.1 | 10 ++++++- +> man/man1/notmuch-search.1 | 11 ++++++++ +> notmuch-count.c | 37 ++++++++++++++++++++++++++ +> notmuch-search.c | 18 ++++++++----- +> test/count | 10 +++++++ +> test/search-output | 65 +++++++++++++++++++++++++++++++++++++++++++++ +> 7 files changed, 156 insertions(+), 7 deletions(-) +> +> -- +> 1.7.10.4 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2