From 2d0e82e20d9398770460aa2dc7136e1e4f2c3f1d Mon Sep 17 00:00:00 2001 From: David Bremner Date: Sun, 10 Apr 2016 08:31:47 +2100 Subject: [PATCH] Re: [PATCH v4 7/7] complete ghost-on-removal-when-shared-thread-exists --- 48/9b781ba0ee2152bb4733c3bd8befc59c1d7d27 | 76 +++++++++++++++++++++++ 1 file changed, 76 insertions(+) create mode 100644 48/9b781ba0ee2152bb4733c3bd8befc59c1d7d27 diff --git a/48/9b781ba0ee2152bb4733c3bd8befc59c1d7d27 b/48/9b781ba0ee2152bb4733c3bd8befc59c1d7d27 new file mode 100644 index 000000000..d2aef0dde --- /dev/null +++ b/48/9b781ba0ee2152bb4733c3bd8befc59c1d7d27 @@ -0,0 +1,76 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 9B7A16DE028C + for ; Sat, 9 Apr 2016 04:31:57 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.019 +X-Spam-Level: +X-Spam-Status: No, score=-0.019 tagged_above=-999 required=5 + tests=[AWL=-0.008, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 931waPqS2z_R for ; + Sat, 9 Apr 2016 04:31:49 -0700 (PDT) +Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) + by arlo.cworth.org (Postfix) with ESMTPS id A16DB6DE0173 + for ; Sat, 9 Apr 2016 04:31:49 -0700 (PDT) +Received: from remotemail by fethera.tethera.net with local (Exim 4.84) + (envelope-from ) + id 1aor7O-0000SI-JO; Sat, 09 Apr 2016 07:31:58 -0400 +Received: (nullmailer pid 24373 invoked by uid 1000); + Sat, 09 Apr 2016 11:31:47 -0000 +From: David Bremner +To: Daniel Kahn Gillmor , + Notmuch Mail +Subject: Re: [PATCH v4 7/7] complete + ghost-on-removal-when-shared-thread-exists +In-Reply-To: <1460166892-29721-7-git-send-email-dkg@fifthhorseman.net> +References: <1459445693-3900-1-git-send-email-dkg@fifthhorseman.net> + <1460166892-29721-1-git-send-email-dkg@fifthhorseman.net> + <1460166892-29721-7-git-send-email-dkg@fifthhorseman.net> +User-Agent: Notmuch/0.21+99~gd93d377 (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Sat, 09 Apr 2016 08:31:47 -0300 +Message-ID: <871t6f3tng.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 09 Apr 2016 11:31:57 -0000 + +Daniel Kahn Gillmor writes: + + +> + status = _notmuch_message_delete (message); +> + if (status) /* we'll report the last failure we see; +> + * if there is more than one failure, we +> + * forget about previous ones */ +> + last_error = status; + +I was initially worried/paranoid that there might be some risk of data +loss by continuing deleting after the first bad status; that doesn't +seem to be the case, but there doesn't seem to be much advantage in +continuing either, since the only error currently returned from +_notmuch_message_delete is from _notmuch_database_ensure_writable, which +seems likely to persist. So perhaps exiting the loop on the first error +might be less confusing. + +Other than that, and my bug in ghost-report, the series looks good to +me. + +d + -- 2.26.2