From 2b533ae06eeed225cdd861b0ec351f1c141dad9e Mon Sep 17 00:00:00 2001 From: "Eric S. Raymond" Date: Sun, 30 Sep 2012 22:03:30 -0400 Subject: [PATCH] Note a bug. --- BUGS | 4 +--- irkerhook.py | 3 ++- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/BUGS b/BUGS index 199419c..2c3e506 100644 --- a/BUGS +++ b/BUGS @@ -3,6 +3,4 @@ * Despite what the header comment implies, the URL prefix and message template in irkerhook.py can at present only be modified by hacking the script. -* DoS attacks on irker instances are not presently very difficult. - Some mechanism for reaping old connections when near exhaustion of - thread instances or file descriptors would be a good idea. +* We shouldn't generate bogus URLS when the repo doesm't have a web view. diff --git a/irkerhook.py b/irkerhook.py index 781670f..bcc8275 100755 --- a/irkerhook.py +++ b/irkerhook.py @@ -68,9 +68,10 @@ class GenericExtractor: self.logmsg = None self.rev = None self.color = False + # Color highlighting is disabled by default. self.bold = self.green = self.blue = "" self.yellow = self.brown = self.reset = "" - def activate_color(self) + def activate_color(self): "IRC color codes." self.bold = '\x02' self.green = '\x033' -- 2.26.2