From 2b068853525fba3ce36f0f129d5872f33ae71222 Mon Sep 17 00:00:00 2001 From: David Edmondson Date: Mon, 8 Feb 2016 17:36:31 +0000 Subject: [PATCH] Re: [Vagrant Cascadian] Bug#759302: notmuch-emacs: citation should use datestring from the replied to message --- 17/f46aa18766b2ee0671224fa417702a7753e86e | 99 +++++++++++++++++++++++ 1 file changed, 99 insertions(+) create mode 100644 17/f46aa18766b2ee0671224fa417702a7753e86e diff --git a/17/f46aa18766b2ee0671224fa417702a7753e86e b/17/f46aa18766b2ee0671224fa417702a7753e86e new file mode 100644 index 000000000..e1a136bca --- /dev/null +++ b/17/f46aa18766b2ee0671224fa417702a7753e86e @@ -0,0 +1,99 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id AE4D46DE0AC2 + for ; Mon, 8 Feb 2016 09:36:37 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[AWL=0.067, + DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7, + RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_NEUTRAL=0.652, + UNPARSEABLE_RELAY=0.001] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id d9tO-v6BP9ph for ; + Mon, 8 Feb 2016 09:36:36 -0800 (PST) +Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com + [74.125.82.53]) by arlo.cworth.org (Postfix) with ESMTPS id AD6C76DE02CE for + ; Mon, 8 Feb 2016 09:36:35 -0800 (PST) +Received: by mail-wm0-f53.google.com with SMTP id g62so126852254wme.0 + for ; Mon, 08 Feb 2016 09:36:35 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=dme-org.20150623.gappssmtp.com; s=20150623; + h=to:subject:in-reply-to:references:from:date:message-id:mime-version + :content-type; bh=Yz6LqjFum88nmbV9nMz8+uEJQUmXTN1rEKi8DJW1kVI=; + b=BeIKt4lPta6S3HuiiDTnv3sDJpg5mEMOkQ84cznZKXd9SXF0G6W0ddnUg7c4wWLhsh + ATFOqUO8dhzSOFSGLnw9bTSCI6e32Ju9YshGiocwqTQA1kx/zDd3SZnETeTaFeUKd9/H + uJ3/FWAFENQL14pQXVsbHsWx359+e9GbGu7LtuY3wmYDCQMXKGLD9/htwIgIUUDGb4/4 + huVWlOOxj0361GWPh+rSjZDMUhXC9Q1s89O6nGXHEXaKENTI9js2TZYREbahPyabIbPM + GkPt4/I6Zuj75sgTtuRmvQT9Z8k4aIRaNTJ2ge/z1I/rh+7nIETj9/FAlb5G5X6SWHK8 + nE1w== +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:to:subject:in-reply-to:references:from:date + :message-id:mime-version:content-type; + bh=Yz6LqjFum88nmbV9nMz8+uEJQUmXTN1rEKi8DJW1kVI=; + b=KcmpW/PRJwkNE2eeg0c79jaOt/1faqsLr+nq6XMkdcevePctb0I/EugPeBIVJFrsTo + UIsDjdt+XHyeq+vb/DOtOIq7Xl1Y0S5k+nSBQVRb4p2d+guXABkvlpPTjp/R5lI+YS2b + 4gJk6aq7bDW/XHrGAXpUAnKsl6/FLSEYDVvhnv6FqVJQCe+2lPqamdPXwn4SrPVR3rKQ + OkYhv5XIveJzGZeQ+5HlEQFXfJ/rF8VtZER9yXl43gxPVj8MaZsF8xmVlPmqmFUXBe0w + zPI3B6NHlJpgRO+PnGkpM9nNVSFNBuWpWi/XGn3W5l9REU4+4olVBl05zt1AyfQLm0Ij + q1gg== +X-Gm-Message-State: + AG10YOT4IyWG7whRxzSqNCuLbd8hWQ2d3w8UMr1moMz7sz/oVHA3j7tRim30359IA2pRSg== +X-Received: by 10.194.71.135 with SMTP id v7mr29201375wju.106.1454952994263; + Mon, 08 Feb 2016 09:36:34 -0800 (PST) +Received: from disaster-area.hh.sledj.net + ([2a01:348:1a2:1:ea39:35ff:fe2c:a227]) + by smtp.gmail.com with ESMTPSA id di1sm30710247wjc.3.2016.02.08.09.36.32 + (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Mon, 08 Feb 2016 09:36:32 -0800 (PST) +Received: from localhost (disaster-area.hh.sledj.net [local]) + by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id 20581fb0; + Mon, 8 Feb 2016 17:36:31 +0000 (UTC) +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [Vagrant Cascadian] Bug#759302: notmuch-emacs: citation should + use datestring from the replied to message +In-Reply-To: <87vboiagrj.fsf@maritornes.cs.unb.ca> +References: <87vboiagrj.fsf@maritornes.cs.unb.ca> +From: David Edmondson +Date: Mon, 08 Feb 2016 17:36:31 +0000 +Message-ID: +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 08 Feb 2016 17:36:37 -0000 + +> So, I've struggled with coming up with a citation line format: +> +> '(message-citation-line-format "On %Y-%m-%d %T %z, %N wrote:") +> '(message-citation-line-function (quote message-insert-formatted-citation-line)) +> +> But it localizes the timezone of datestring, rather than simply copying +> the datestring from the replied to message. + +This is not something that we can fix (as is alluded to in the Debian +bug report). + +`message-insert-formatted-citation-line' converts the date of the +message being replied to into Emacs time (a list of two integers) and +then uses `format-time-string' with the result. + +All of the timezone information from the original header is lost during +the conversion to Emacs time. + +Do we typically just open an upstream emacs bug in such cases? -- 2.26.2