From 2a97a287f8e1dfb0638f167c441abf077b2678b6 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Fri, 7 Nov 2014 08:24:08 +0000 Subject: [PATCH] Re: [PATCH] cli: notmuch address option defaults update --- d1/7092b51d226ae23f1f52c32346f20645c1b341 | 247 ++++++++++++++++++++++ 1 file changed, 247 insertions(+) create mode 100644 d1/7092b51d226ae23f1f52c32346f20645c1b341 diff --git a/d1/7092b51d226ae23f1f52c32346f20645c1b341 b/d1/7092b51d226ae23f1f52c32346f20645c1b341 new file mode 100644 index 000000000..2ff538b04 --- /dev/null +++ b/d1/7092b51d226ae23f1f52c32346f20645c1b341 @@ -0,0 +1,247 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 21C72431FB6 + for ; Fri, 7 Nov 2014 00:24:42 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id OHGbSQbaWWtk for ; + Fri, 7 Nov 2014 00:24:33 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 06A8B431FAE + for ; Fri, 7 Nov 2014 00:24:32 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1Xmeq1-0003xw-Fw; Fri, 07 Nov 2014 08:24:29 +0000 +Received: from 5751dfa2.skybroadband.com ([87.81.223.162] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1Xmeq0-0005ZV-S5; Fri, 07 Nov 2014 08:24:09 +0000 +From: Mark Walters +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH] cli: notmuch address option defaults update +In-Reply-To: <1415297516-29203-1-git-send-email-tomi.ollila@iki.fi> +References: <1415297516-29203-1-git-send-email-tomi.ollila@iki.fi> +User-Agent: Notmuch/0.18.1+86~gef5e66a (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Fri, 07 Nov 2014 08:24:08 +0000 +Message-ID: <871tpf1krb.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 87.81.223.162 +X-QM-Geographic: According to ripencc, + this message was delivered by a machine in Britain (UK) (GB). +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 76169b25e71e638a9e6f4cac38d4d3ce (of first 20000 bytes) +X-SpamAssassin-Score: -0.1 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -0.1 points. + Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.1 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +Cc: tomi.ollila@iki.fi +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 07 Nov 2014 08:24:42 -0000 + + +Hi + +On Thu, 06 Nov 2014, Tomi Ollila wrote: +> When no --output option were given, change default to display senders +> only. This is faster and provides useful-enough list of addresses. +> +> When only --count option is given, display senders (in contrary to not +> displaying anything). +> +> Document how --count affects to "sort order" a bit more accurately. +> +> Clean up some whitespace in the documentation. +> +> One test updated to have --output=count without sender nor recipient +> output option. +> --- +> +> Some quick updates to the notmuch address interface which I hope will +> be considered to be included in 0.19 release. As we are in feature freeze +> I hope this gets quick feedback, in any way you desire. + +I have tested it and it basically looks good. (As mentioned +on irc) I am mildly in favour of the change to defaulting to +output=sender that this patch does. + +A couple of comments below. Feel free to ignore. + +> Tomi +> +> doc/man1/notmuch-address.rst | 34 ++++++++++++++++++---------------- +> notmuch-search.c | 4 ++-- +> test/T095-address.sh | 14 +++++++------- +> 3 files changed, 27 insertions(+), 25 deletions(-) +> +> diff --git a/doc/man1/notmuch-address.rst b/doc/man1/notmuch-address.rst +> index 359616e0dc5f..034607c434d2 100644 +> --- a/doc/man1/notmuch-address.rst +> +++ b/doc/man1/notmuch-address.rst +> @@ -32,28 +32,28 @@ Supported options for **address** include +> ``--output=(sender|recipients|count)`` +> +> Controls which information appears in the output. This option +> - can be given multiple times to combine different outputs. +> - Omitting this option is equivalent to +> - --output=sender --output=recipients. +> + can be given multiple times to combine different outputs. +> + Omitting this option is equivalent to --output=sender. + +Perhaps say, "if neither --output=sender nor --output=recipients is +specified then this defaults to --output=sender". (Otherwise the manual +does not specify what happens in --output=count case) + +> - **sender** +> + **sender** +> Output all addresses from the *From* header. +> +> - Note: Searching for **sender** should be much faster than +> - searching for **recipients**, because sender addresses are +> - cached directly in the database whereas other addresses +> - need to be fetched from message files. +> + Note: Searching for **sender** should be much faster than +> + searching for **recipients**, because sender addresses are +> + cached directly in the database whereas other addresses +> + need to be fetched from message files. +> +> - **recipients** +> + **recipients** +> Output all addresses from the *To*, *Cc* and *Bcc* +> headers. +> +> - **count** +> - Print the count of how many times was the address +> - encountered during search. +> + **count** +> + Print the count of how many times was the address +> + encountered during search. +> +> - Note: With this option, addresses are printed only after +> - the whole search is finished. This may take long time. +> + Note: With this option, addresses are printed only after +> + the whole search is finished (and in seemingly random +> + order). This may take long time. +> +> ``--sort=``\ (**newest-first**\ \|\ **oldest-first**) +> This option can be used to present results in either +> @@ -63,7 +63,9 @@ Supported options for **address** include +> By default, results will be displayed in reverse chronological +> order, (that is, the newest results will be displayed first). +> +> - This option has no effect when used with --output=count. +> + This option affects the seemingly random output order when +> + used with --output=count. + +I know what this means but it confused me at first. How about "When +used with --output=count this option changes the output from one +seemingly random order to a different seemingly random order"? + +Best wishes + +Mark + + +> +> ``--exclude=(true|false)`` +> A message is called "excluded" if it matches at least one tag in +> @@ -95,4 +97,4 @@ SEE ALSO +> **notmuch-dump(1)**, **notmuch-hooks(5)**, **notmuch-insert(1)**, +> **notmuch-new(1)**, **notmuch-reply(1)**, **notmuch-restore(1)**, +> **notmuch-search-terms(7)**, **notmuch-show(1)**, **notmuch-tag(1)**, +> -***notmuch-search(1)** +> +**notmuch-search(1)** +> diff --git a/notmuch-search.c b/notmuch-search.c +> index 5036d8e44005..14b9f01c5ad1 100644 +> --- a/notmuch-search.c +> +++ b/notmuch-search.c +> @@ -735,8 +735,8 @@ notmuch_address_command (notmuch_config_t *config, int argc, char *argv[]) +> if (opt_index < 0) +> return EXIT_FAILURE; +> +> - if (! ctx->output) +> - ctx->output = OUTPUT_SENDER | OUTPUT_RECIPIENTS; +> + if (! (ctx->output & (OUTPUT_SENDER | OUTPUT_RECIPIENTS))) +> + ctx->output |= OUTPUT_SENDER; +> +> if (_notmuch_search_prepare (ctx, config, +> argc - opt_index, argv + opt_index)) +> diff --git a/test/T095-address.sh b/test/T095-address.sh +> index 033d0f4fd68c..ed0cac7807ff 100755 +> --- a/test/T095-address.sh +> +++ b/test/T095-address.sh +> @@ -27,6 +27,11 @@ Mikhail Gusarov +> EOF +> test_expect_equal_file OUTPUT EXPECTED +> +> +test_begin_subtest "without --output" +> +notmuch address '*' >OUTPUT +> +# Use EXPECTED from previous subtest +> +test_expect_equal_file OUTPUT EXPECTED +> + +> test_begin_subtest "--output=sender --format=json" +> notmuch address --output=sender --format=json '*' >OUTPUT +> cat <EXPECTED +> @@ -91,11 +96,6 @@ Mikhail Gusarov +> EOF +> test_expect_equal_file OUTPUT EXPECTED +> +> -test_begin_subtest "without --output" +> -notmuch address '*' >OUTPUT +> -# Use EXPECTED from previous subtest +> -test_expect_equal_file OUTPUT EXPECTED +> - +> test_begin_subtest "--output=sender --output=count" +> notmuch address --output=sender --output=count '*' | sort -n >OUTPUT +> cat <EXPECTED +> @@ -119,10 +119,10 @@ cat <EXPECTED +> EOF +> test_expect_equal_file OUTPUT EXPECTED +> +> -test_begin_subtest "--output=sender --output=count --format=json" +> +test_begin_subtest "--output=count --format=json" +> # Since the iteration order of GHashTable is not specified, we +> # preprocess and sort the results to keep the order stable here. +> -notmuch address --output=sender --output=count --format=json '*' | \ +> +notmuch address --output=count --format=json '*' | \ +> sed -e 's/^\[//' -e 's/]$//' -e 's/,$//' | sort >OUTPUT +> cat <EXPECTED +> {"name": "Adrian Perez de Castro", "address": "aperez@igalia.com", "name-addr": "Adrian Perez de Castro ", "count": 1} +> -- +> 2.0.0 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2