From 29d5f3b11cad51fa4b4ffa20cdfc0681d11a0d23 Mon Sep 17 00:00:00 2001 From: "W. Trevor King" Date: Sat, 27 Oct 2012 11:38:20 -0400 Subject: [PATCH] storage:vcs:git: don't accept pygit2 version 0.17.3. MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit My Repository.revparse_single() series was merged into pygit2 with: Merge: 3e9daa4 0238fb7 Author: J. David Ibáñez Date: Tue Sep 25 15:10:55 2012 +0200 Merge remote-tracking branch 'wking/revparse' But this happened after the 0.17.3 release. The next pygit2 release should contain the .revparse_single() code. The getattr() hackery works because versions of pygit2 before 0.17.3 lacked a __version__ attribute. --- libbe/storage/vcs/git.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libbe/storage/vcs/git.py b/libbe/storage/vcs/git.py index 7cf4652..acdce15 100644 --- a/libbe/storage/vcs/git.py +++ b/libbe/storage/vcs/git.py @@ -36,10 +36,10 @@ except ImportError, error: _pygit2 = None _pygit2_import_error = error else: - if not hasattr(_pygit2, '__version__'): + if getattr(_pygit2, '__version__', '0.17.3') == '0.17.3': _pygit2 = None _pygit2_import_error = NotImplementedError( - 'pygit2 <= 0.17.2 not supported') + 'pygit2 <= 0.17.3 not supported') import libbe from ...ui.util import user as _user -- 2.26.2