From 29a9e66088690bfc07c3ba33ea025dba9b202bd5 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Sat, 11 Jan 2014 20:50:00 +0200 Subject: [PATCH] Re: [PATCH] test/emacs: replace the use of process-attributes with signal-process --- 0d/33424878865b6f7e78db4b348c67ffced32d95 | 130 ++++++++++++++++++++++ 1 file changed, 130 insertions(+) create mode 100644 0d/33424878865b6f7e78db4b348c67ffced32d95 diff --git a/0d/33424878865b6f7e78db4b348c67ffced32d95 b/0d/33424878865b6f7e78db4b348c67ffced32d95 new file mode 100644 index 000000000..0a47bdc0f --- /dev/null +++ b/0d/33424878865b6f7e78db4b348c67ffced32d95 @@ -0,0 +1,130 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 561A3431FD0 + for ; Sat, 11 Jan 2014 10:50:20 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 6ixgn8U851wQ for ; + Sat, 11 Jan 2014 10:50:08 -0800 (PST) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id BB955431FC3 + for ; Sat, 11 Jan 2014 10:50:08 -0800 (PST) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id B5A9610005E; + Sat, 11 Jan 2014 20:50:00 +0200 (EET) +From: Tomi Ollila +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH] test/emacs: replace the use of process-attributes with + signal-process +In-Reply-To: <1389461139-20249-1-git-send-email-david@tethera.net> +References: + <1389461139-20249-1-git-send-email-david@tethera.net> +User-Agent: Notmuch/0.17+23~ga575e35 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 11 Jan 2014 18:50:20 -0000 + +On Sat, Jan 11 2014, David Bremner wrote: + +> In some environments (at least Hurd), process-attributes is +> unimplimented and always returns nil. This ends up causing test +> failures (see e.g. id:87a9ffofsc.fsf@zancas.localnet). +> +> Historically and according to POSIX 1003.1-2001, a signal of 0 can be +> used to check the validity of a pid. This seems less heinous than +> parsing the output of ps(1). +> --- +> +> Thanks to Domo for the simpler solution. Now that I think about it, +> perhaps this makes sense as a debian only update, since it currently +> fails only on Debian/Hurd, which according to the GNU project is the +> only "working distribution + +Would an ultimate(tm) solution be: + + (defun orphan-watchdog (pid) + "Initiate orphan watchdog check." + (run-at-time 60 60 + (if (process-attributes pid) + (lambda (pid) (if (not (process-attributes pid) (kill-emacs)))) + (lambda (pid) (if (/= 0 (signal-process pid 0)) (kill-emacs)))) + pid)) + +of course the lambdas can be replaced w/ symbols to functions, just +compressed for this example -- also w/ appropriate commit messages... + +This could work on unices, hurd, windows, whatnot... + + +Anyway, the current patch also LGTM. + +Tomi + +> +> test/test-lib.el | 15 +++++++++------ +> 1 file changed, 9 insertions(+), 6 deletions(-) +> +> diff --git a/test/test-lib.el b/test/test-lib.el +> index d26b49f..37fcb3d 100644 +> --- a/test/test-lib.el +> +++ b/test/test-lib.el +> @@ -77,19 +77,22 @@ invisible text." +> (setq start next-pos))) +> str)) +> +> +;; process-attributes is not defined everywhere, so define an +> +;; alternate way to test if a process still exists. +> + +> +(defun test-process-running (pid) +> + (= 0 +> + (signal-process pid 0))) +> + +> (defun orphan-watchdog-check (pid) +> "Periodically check that the process with id PID is still +> running, quit if it terminated." +> - (if (not (process-attributes pid)) +> + (if (not (test-process-running pid)) +> (kill-emacs))) +> +> (defun orphan-watchdog (pid) +> "Initiate orphan watchdog check." +> - ; If process-attributes returns nil right away, that probably means +> - ; it is unimplimented. So we delay two minutes before killing emacs. + +Btw: who let this typo above pass through review ? ;) + +> - (if (process-attributes pid) +> - (run-at-time 60 60 'orphan-watchdog-check pid) +> - (run-at-time 120 60 'orphan-watchdog-check pid))) +> + (run-at-time 60 60 'orphan-watchdog-check pid)) +> +> (defun hook-counter (hook) +> "Count how many times a hook is called. Increments +> -- +> 1.8.5.2 -- 2.26.2