From 29083bdf0438b9282d189a6b902f9ccd06cf714d Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Sun, 15 Sep 2013 15:35:06 +0100 Subject: [PATCH] [PATCH 3/3] contrib: pick: remove unused notmuch-pick-from-hello --- 35/4e2bd413433e25caee5a063696314ce22bbb29 | 96 +++++++++++++++++++++++ 1 file changed, 96 insertions(+) create mode 100644 35/4e2bd413433e25caee5a063696314ce22bbb29 diff --git a/35/4e2bd413433e25caee5a063696314ce22bbb29 b/35/4e2bd413433e25caee5a063696314ce22bbb29 new file mode 100644 index 000000000..487e14d63 --- /dev/null +++ b/35/4e2bd413433e25caee5a063696314ce22bbb29 @@ -0,0 +1,96 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id A4E32431FAE + for ; Sun, 15 Sep 2013 07:35:25 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.201 +X-Spam-Level: +X-Spam-Status: No, score=0.201 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001, + RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id ykk3k8z0JavV for ; + Sun, 15 Sep 2013 07:35:21 -0700 (PDT) +Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com + [74.125.82.51]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client + certificate requested) by olra.theworths.org (Postfix) with ESMTPS id + 74D04431FBF for ; Sun, 15 Sep 2013 07:35:17 -0700 + (PDT) +Received: by mail-wg0-f51.google.com with SMTP id c11so2775140wgh.30 + for ; Sun, 15 Sep 2013 07:35:16 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:cc:subject:date:message-id:in-reply-to:references; + bh=QW9s3OJlY/AukA/tIK8dTcmEK3n3z905+YyHXYEFsdg=; + b=xNtfiF4JPbzvS9eMgKx03lDKRc6/aE/a4H70mEkuAhMi/vx/vkMEIXDdr/+TWezuLU + pieW0RA7M3kNc0QVDw/f3jY2Jjd1kJPsfysXBpNAz81rH5zHj8DVrZR36KdYAkIPHsue + +z0lxCwwhZcoTEnW0AbTovDE2BG/K5w+jl2kwmQuvZJhwL8U2qQUglKrw3oUj11W8Jqn + ohGlmNhiGAuJNI0IBlTsHtjNBcLH0kPgK55oXApp+BQa5vnd+6mmSmun1U7b1ZuzAxx9 + jfaFKv/+HMq2Tvt7c9ejUDMudJ6Z5/Faeme6Uwnq18uv6czQp3WkKY/9tMclGhnpvFqk + vhUg== +X-Received: by 10.180.108.162 with SMTP id hl2mr9860424wib.14.1379255716351; + Sun, 15 Sep 2013 07:35:16 -0700 (PDT) +Received: from localhost (93-97-24-31.zone5.bethere.co.uk. [93.97.24.31]) + by mx.google.com with ESMTPSA id + dl10sm15535640wib.1.1969.12.31.16.00.00 + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Sun, 15 Sep 2013 07:35:16 -0700 (PDT) +From: Mark Walters +To: notmuch@notmuchmail.org +Subject: [PATCH 3/3] contrib: pick: remove unused notmuch-pick-from-hello +Date: Sun, 15 Sep 2013 15:35:06 +0100 +Message-Id: <1379255706-2418-4-git-send-email-markwalters1009@gmail.com> +X-Mailer: git-send-email 1.7.9.1 +In-Reply-To: <1379255706-2418-1-git-send-email-markwalters1009@gmail.com> +References: <1379255706-2418-1-git-send-email-markwalters1009@gmail.com> +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 15 Sep 2013 14:35:25 -0000 + +This function was used for pick entry from hello but isn't needed +anymore. It was modelled on notmuch-hello-search which is now only +used non-interactively (and notmuch-pick does now add to the +recent-search history correctly). +--- + contrib/notmuch-pick/notmuch-pick.el | 11 ----------- + 1 files changed, 0 insertions(+), 11 deletions(-) + +diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el +index 386fef5..69bea2a 100644 +--- a/contrib/notmuch-pick/notmuch-pick.el ++++ b/contrib/notmuch-pick/notmuch-pick.el +@@ -428,17 +428,6 @@ Does NOT change the database." + (notmuch-pick-close-message-window) + (notmuch-pick query))) + +-;; This function should be in notmuch-hello.el but we are trying to +-;; minimise impact on the rest of the codebase. +-(defun notmuch-pick-from-hello (&optional search) +- "Run a query and display results in experimental notmuch-pick mode" +- (interactive) +- (unless (null search) +- (setq search (notmuch-hello-trim search)) +- (let ((history-delete-duplicates t)) +- (add-to-history 'notmuch-search-history search))) +- (notmuch-pick search)) +- + ;; This function should be in notmuch-show.el but be we trying to + ;; minimise impact on the rest of the codebase. + (defun notmuch-pick-from-show-current-query () +-- +1.7.9.1 + -- 2.26.2