From 26de1807e5f43cce50226b470a01fa8c16d68fae Mon Sep 17 00:00:00 2001 From: David Bremner Date: Wed, 1 Apr 2015 08:59:29 +0200 Subject: [PATCH] Re: [PATCH] emacs: show: hide large text attachments by default --- 81/31c740ede93a9ab6a5e8885bc4693ff392c483 | 65 +++++++++++++++++++++++ 1 file changed, 65 insertions(+) create mode 100644 81/31c740ede93a9ab6a5e8885bc4693ff392c483 diff --git a/81/31c740ede93a9ab6a5e8885bc4693ff392c483 b/81/31c740ede93a9ab6a5e8885bc4693ff392c483 new file mode 100644 index 000000000..0960d4c15 --- /dev/null +++ b/81/31c740ede93a9ab6a5e8885bc4693ff392c483 @@ -0,0 +1,65 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 5F5FD6DE1994 + for ; Fri, 3 Apr 2015 16:03:47 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 1.23 +X-Spam-Level: * +X-Spam-Status: No, score=1.23 tagged_above=-999 required=5 tests=[AWL=0.426, + DATE_IN_PAST_12_24=0.804] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id pM3q-5TGm5q9 for ; + Fri, 3 Apr 2015 16:03:45 -0700 (PDT) +Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net + [87.98.215.224]) + by arlo.cworth.org (Postfix) with ESMTPS id AE7F56DE1992 + for ; Fri, 3 Apr 2015 16:03:45 -0700 (PDT) +Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim + 4.80) (envelope-from ) + id 1YdXGE-0003SI-Vg; Thu, 02 Apr 2015 05:01:47 +0000 +Received: (nullmailer pid 22244 invoked by uid 1000); Wed, 01 Apr 2015 + 06:59:29 -0000 +From: David Bremner +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: show: hide large text attachments by default +In-Reply-To: <1427540939-10055-1-git-send-email-markwalters1009@gmail.com> +References: <1427540939-10055-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.19+96~g703c8f9 (http://notmuchmail.org) Emacs/24.4.1 + (x86_64-pc-linux-gnu) +Date: Wed, 01 Apr 2015 08:59:29 +0200 +Message-ID: <877ftw49m6.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 03 Apr 2015 23:03:47 -0000 + +Mark Walters writes: + +> +> This code is getting a little fragile -- there are quite a lot of +> factors in deciding whether to show or hide a part and the code is +> called from both show and reply -- but it seems to work. For testing I +> suggest setting notmuch-show-max-text-part-size to something small +> like 100 or 1000. + +The change looks ok, and as I mentioned it in a previous mail, it seems +to work well, at least for the notmuch-show bottleneck I know how to +test. + +d + -- 2.26.2