From 2692580e03be19832538053077786459e09df460 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Sat, 24 Aug 2013 10:18:46 +0300 Subject: [PATCH] Re: [PATCH] Switch to DEF from INITIAL-INPUT in completing-read. --- 9c/3faba67ceb4d85e95c03b1e04dc87a753d5761 | 83 +++++++++++++++++++++++ 1 file changed, 83 insertions(+) create mode 100644 9c/3faba67ceb4d85e95c03b1e04dc87a753d5761 diff --git a/9c/3faba67ceb4d85e95c03b1e04dc87a753d5761 b/9c/3faba67ceb4d85e95c03b1e04dc87a753d5761 new file mode 100644 index 000000000..69060651d --- /dev/null +++ b/9c/3faba67ceb4d85e95c03b1e04dc87a753d5761 @@ -0,0 +1,83 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 20F80431FCF + for ; Sat, 24 Aug 2013 00:19:03 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 9hubbYAhZbQM for ; + Sat, 24 Aug 2013 00:18:54 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id C2006431FBF + for ; Sat, 24 Aug 2013 00:18:54 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 897E4100086; + Sat, 24 Aug 2013 10:18:46 +0300 (EEST) +From: Tomi Ollila +To: Christopher Wellons , notmuch@notmuchmail.org +Subject: Re: [PATCH] Switch to DEF from INITIAL-INPUT in completing-read. +In-Reply-To: <87k3jdgnqe.fsf@susie.zeus.nullprogram.com> +References: <1377103488-7425-1-git-send-email-wellons@nullprogram.com> + + + <87k3jdgnqe.fsf@susie.zeus.nullprogram.com> +User-Agent: Notmuch/0.16+11~gf21768f (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 24 Aug 2013 07:19:03 -0000 + +On Fri, Aug 23 2013, Christopher Wellons wrote: + +> Tomi Ollila writes: +> +>>> I agree that this behaves better, but the empty content with completing-read +>>> looks a bit confusing (if arrow keys or tab aren't pressed) +> +> You're right. Taking a look at this with completing-read I see it's not +> obvious what defaulting will do. +> +>> we could also drop the default/initial input: +> +> The default is usually what I want to select, so I like being able to +> just hit tab/enter to select it. +> +>>> I don't know how ido-replaced completing-read (just ido-completing-read ?) +>>> works there, though. +> +> I'm using ido-ubiquitous, which installs ido-completing-read overtop +> completing-read along with some compatability tweaks. + +The compatibility tweaks doesn't seem to be enough ;/ + +One option would be to so somehow to detect that completing-read is +actually replaced with something (anything?) else and arrange the +arguments differently. I think in this case such a feature +could be tolerated... :D + + +Tomi -- 2.26.2