From 244f05ab44e5ec3f71317dc02518e3aa468e783e Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Sun, 1 Sep 2013 19:34:41 +0100 Subject: [PATCH] Re: [Patch v2 0/3] contrib: pick: remove an unused variable --- f2/6422ad20df4a3df523fe9179187bebb8dd609e | 110 ++++++++++++++++++++++ 1 file changed, 110 insertions(+) create mode 100644 f2/6422ad20df4a3df523fe9179187bebb8dd609e diff --git a/f2/6422ad20df4a3df523fe9179187bebb8dd609e b/f2/6422ad20df4a3df523fe9179187bebb8dd609e new file mode 100644 index 000000000..6daa1ef3b --- /dev/null +++ b/f2/6422ad20df4a3df523fe9179187bebb8dd609e @@ -0,0 +1,110 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 181DF431FC9 + for ; Mon, 2 Sep 2013 03:06:42 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id UUHL7NUO7gZ4 for ; + Mon, 2 Sep 2013 03:06:34 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 7FB53431FC3 + for ; Mon, 2 Sep 2013 03:06:34 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1VGCTy-0005iW-Vh; Sun, 01 Sep 2013 19:34:43 +0100 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1VGCTy-0001z0-PU; Sun, 01 Sep 2013 19:34:42 +0100 +From: Mark Walters +To: notmuch@notmuchmail.org +Subject: Re: [Patch v2 0/3] contrib: pick: remove an unused variable +In-Reply-To: <1377551345-27147-1-git-send-email-markwalters1009@gmail.com> +References: <1377551345-27147-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.15.2+269~g01f5508 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Sun, 01 Sep 2013 19:34:41 +0100 +Message-ID: <87ioykie66.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 0eee6cae1ccca83744e7424a471126c2 (of first 20000 bytes) +X-SpamAssassin-Score: 0.0 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored 0.0 points. Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * 0.0 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 02 Sep 2013 10:06:42 -0000 + + +I should have included a diff from v2: see below (obviously the test in +patch 3 is also new). + +Best wishes + +Mark + + + +diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el +index f6710e9..5d46d42 100644 +--- a/contrib/notmuch-pick/notmuch-pick.el ++++ b/contrib/notmuch-pick/notmuch-pick.el +@@ -812,7 +812,7 @@ Complete list of currently available key bindings: + (setq search-args basic-query)) + (if notmuch-pick-asynchronous-parser + (let ((proc (notmuch-start-notmuch +- "notmuch-pick" buffer #'notmuch-pick-process-sentinel ++ "notmuch-pick" (current-buffer) #'notmuch-pick-process-sentinel + "show" "--body=false" "--format=sexp" + message-arg search-args)) + ;; Use a scratch buffer to accumulate partial output. +@@ -853,13 +853,13 @@ The arguments are: + (concat "*notmuch-pick-" query "*"))))) + (inhibit-read-only t)) + +- (switch-to-buffer buffer) +- ;; Don't track undo information for this buffer +- (set 'buffer-undo-list t) ++ (switch-to-buffer buffer)) ++ ;; Don't track undo information for this buffer ++ (set 'buffer-undo-list t) + +- (notmuch-pick-worker query query-context target open-target) ++ (notmuch-pick-worker query query-context target open-target) + +- (setq truncate-lines t))) ++ (setq truncate-lines t)) + + + ;; Set up key bindings from the rest of notmuch. -- 2.26.2