From 2447e1218d42df0d0742b3933b392279179be165 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Thu, 16 Jan 2014 09:29:24 +2000 Subject: [PATCH] Re: [PATCH 2/2] cli: define config getters and setters using a macro --- e4/686120b09af537605f5127a5d4c2c7f39bacf0 | 67 +++++++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100644 e4/686120b09af537605f5127a5d4c2c7f39bacf0 diff --git a/e4/686120b09af537605f5127a5d4c2c7f39bacf0 b/e4/686120b09af537605f5127a5d4c2c7f39bacf0 new file mode 100644 index 000000000..6cf7869fd --- /dev/null +++ b/e4/686120b09af537605f5127a5d4c2c7f39bacf0 @@ -0,0 +1,67 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 7B4EB431FBD + for ; Wed, 15 Jan 2014 05:29:33 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id mz2P3iGp736n for ; + Wed, 15 Jan 2014 05:29:28 -0800 (PST) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 69362431FAF + for ; Wed, 15 Jan 2014 05:29:28 -0800 (PST) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1W3QX9-0005hM-N9; Wed, 15 Jan 2014 09:29:27 -0400 +Received: (nullmailer pid 24903 invoked by uid 1000); Wed, 15 Jan 2014 + 13:29:24 -0000 +From: David Bremner +To: Jani Nikula , notmuch@notmuchmail.org +Subject: Re: [PATCH 2/2] cli: define config getters and setters using a macro +In-Reply-To: <1376839205-5115-2-git-send-email-jani@nikula.org> +References: <1376839205-5115-1-git-send-email-jani@nikula.org> + <1376839205-5115-2-git-send-email-jani@nikula.org> +User-Agent: Notmuch/0.17+30~g50677dd (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Wed, 15 Jan 2014 09:29:24 -0400 +Message-ID: <87y52hidaj.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 15 Jan 2014 13:29:33 -0000 + +Jani Nikula writes: + +> There's plenty of duplicated code in defining the functions for config +> get/set. Add macros to define the functions. +> +> --- +> +> This might be a bit too tricky for some people's tastes... let's see! +> ;) + +I could go either way on this. I don't find it unbearably tricky; I'm +also not 100% sure it's needed. But if you and Tomi still like the idea, +I'm ok with it. + +d -- 2.26.2