From 22052031cb75d4271a49af5972185b6e3a4d0438 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Thu, 5 Dec 2013 20:04:28 +0000 Subject: [PATCH] [PATCH WIP v3 0/3] emacs: show: change the unread handling --- 66/b094ade7d50a23bddcf793d5fcf8484731298d | 103 ++++++++++++++++++++++ 1 file changed, 103 insertions(+) create mode 100644 66/b094ade7d50a23bddcf793d5fcf8484731298d diff --git a/66/b094ade7d50a23bddcf793d5fcf8484731298d b/66/b094ade7d50a23bddcf793d5fcf8484731298d new file mode 100644 index 000000000..760e665c9 --- /dev/null +++ b/66/b094ade7d50a23bddcf793d5fcf8484731298d @@ -0,0 +1,103 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id B6EA6431FDD + for ; Thu, 5 Dec 2013 12:04:51 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 2.7 +X-Spam-Level: ** +X-Spam-Status: No, score=2.7 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001, + FREEMAIL_REPLY=2.499, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id isZk071hRA1C for ; + Thu, 5 Dec 2013 12:04:44 -0800 (PST) +Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com + [74.125.82.49]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client + certificate requested) by olra.theworths.org (Postfix) with ESMTPS id + 0A369431FD4 for ; Thu, 5 Dec 2013 12:04:43 -0800 + (PST) +Received: by mail-wg0-f49.google.com with SMTP id x12so17407432wgg.16 + for ; Thu, 05 Dec 2013 12:04:41 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:cc:subject:date:message-id; + bh=YRy6isTbdlkf7ZRF10JMdrAZ5vlCZIyHUskbQ1Lh3zA=; + b=ekXG2Qh79AsJm38wiySJgHnUJ6kbDUEV7dQqMKB0mOgs619fQ51N0E6qpfP6HfLXMb + L2Ck3/CjCLx+7dKn8hZqTy+QISZfFsPpMgrE6VFcfSJhog65VnbzuHd9oXe5aBKbM3f1 + q54nK55F/M2f23iPX+HJPa3NMt9Ja13RloZP0bcgLy9dLpDbfrwtrExSM0Mr2uKHe8Ow + Z0lmlucl2Hnkpqz6vxedSkKRz7Gi2RHkSTxxcoaT0G+RzcfD3OgQZgTS0aNo/YZ1g98Q + QLcV1KWyFxK+gbjOnFn306uGfjOyzK6/cSqPJNUk9hfDY44HOZh5rc1TEM6+TZlK1HPd + 1HoQ== +X-Received: by 10.194.2.108 with SMTP id 12mr18981816wjt.64.1386273880116; + Thu, 05 Dec 2013 12:04:40 -0800 (PST) +Received: from localhost (93-97-24-31.zone5.bethere.co.uk. [93.97.24.31]) + by mx.google.com with ESMTPSA id n6sm9412650wix.3.2013.12.05.12.04.38 + for + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Thu, 05 Dec 2013 12:04:39 -0800 (PST) +From: Mark Walters +To: notmuch@notmuchmail.org +Subject: [PATCH WIP v3 0/3] emacs: show: change the unread handling +Date: Thu, 5 Dec 2013 20:04:28 +0000 +Message-Id: <1386273871-24214-1-git-send-email-markwalters1009@gmail.com> +X-Mailer: git-send-email 1.7.9.1 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 05 Dec 2013 20:04:51 -0000 + +This is the next iteration of this WIP patch series. v2 was at +id:1385892147-16994-1-git-send-email-markwalters1009@gmail.com + +I would just like to emphasise that *all* feedback is appreciated +including "I HATE IT" etc. + +I have followed Jani's suggestion and removed the delayed updates to +unread status: it makes it harder to see if the heuristics are doing +what you want. + +The first patch is completely new: it makes all tag changes in a +buffer (in particular the unread tag) clearly visible to the user: a +deleted tag is displayed with red strike-through and an added tag is +displayed underlined in green. (This may have strange interactions with +notmuch-tag-formats in some cases.) + +This makes the visual feedback when a message is marked unread very +clear: the unread tag is struck-through. + +As always with the previous series lots of tests will fail for the +obvious reason that marking read is done differently and displayed +differently. + +Best wishes + +Mark + + + + +Mark Walters (3): + emacs: show: mark tags changed since buffer loaded + emacs: show: add an update seen function to post-command-hook + emacs: show: make `seen' mean user viewed whole message + + emacs/notmuch-show.el | 136 +++++++++++++++++++++++++++++++++++++++++------- + emacs/notmuch-tag.el | 30 +++++++---- + 2 files changed, 136 insertions(+), 30 deletions(-) + +-- +1.7.9.1 + -- 2.26.2