From 21d427a0db539dfb667bed03ae26438dd70722f0 Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Tue, 7 Oct 2014 12:03:56 +2000 Subject: [PATCH] Re: [PATCH 06/11] lib: Internal support for querying and creating ghost messages --- 28/8ab7e379e09d10f501499ac7ae754c8837e7cf | 102 ++++++++++++++++++++++ 1 file changed, 102 insertions(+) create mode 100644 28/8ab7e379e09d10f501499ac7ae754c8837e7cf diff --git a/28/8ab7e379e09d10f501499ac7ae754c8837e7cf b/28/8ab7e379e09d10f501499ac7ae754c8837e7cf new file mode 100644 index 000000000..507073071 --- /dev/null +++ b/28/8ab7e379e09d10f501499ac7ae754c8837e7cf @@ -0,0 +1,102 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1B28A431FB6 + for ; Mon, 6 Oct 2014 09:04:07 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.024 +X-Spam-Level: +X-Spam-Status: No, score=-2.024 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3, URIBL_RHS_DOB=0.276] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id hRskUs3EE4zB for ; + Mon, 6 Oct 2014 09:03:58 -0700 (PDT) +Received: from outgoing.csail.mit.edu (outgoing.csail.mit.edu [128.30.2.149]) + by olra.theworths.org (Postfix) with ESMTP id 8ADA6431FAE + for ; Mon, 6 Oct 2014 09:03:58 -0700 (PDT) +Received: from [104.131.20.129] (helo=awakeningjr) + by outgoing.csail.mit.edu with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) + (Exim 4.72) (envelope-from ) + id 1XbAlQ-0001OJ-VP; Mon, 06 Oct 2014 12:03:57 -0400 +Received: from amthrax by awakeningjr with local (Exim 4.84) + (envelope-from ) + id 1XbAlQ-0001CN-KL; Mon, 06 Oct 2014 12:03:56 -0400 +From: Austin Clements +To: David Bremner +Subject: Re: [PATCH 06/11] lib: Internal support for querying and creating + ghost messages +In-Reply-To: <87y4stoh41.fsf@maritornes.cs.unb.ca> +References: <1412345958-8278-1-git-send-email-aclements@csail.mit.edu> + <1412345958-8278-7-git-send-email-aclements@csail.mit.edu> + <87fvf2q5p5.fsf@maritornes.cs.unb.ca> + <20141005232400.GC7970@csail.mit.edu> + <87y4stoh41.fsf@maritornes.cs.unb.ca> +User-Agent: Notmuch/0.18.1+86~gef5e66a (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Mon, 06 Oct 2014 12:03:56 -0400 +Message-ID: <87k34dchhv.fsf@csail.mit.edu> +MIME-Version: 1.0 +Content-Type: text/plain +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 06 Oct 2014 16:04:07 -0000 + +On Mon, 06 Oct 2014, David Bremner wrote: +> Austin Clements writes: +> +>> +>> I'm used to reading this stuff, so either way is fine with me. Do we +>> have bit set / clear / read macros? +>> +> +> I guess not. the things we have in query.cc are related but different. + +I added some macros for doing this to notmuch-private.h and converted +the other bit twiddling for message flags to use these. + +>>> > + else if (*i == "Tghost") +>>> > + message->flags |= (1 << NOTMUCH_MESSAGE_FLAG_GHOST); +>>> > + else +>>> +>>> It makes me faintly unhappy to have the prefix hardcoded here. +>>> Not sure if there is a sensible solution. +>> +>> I agree, but I also don't want to construct the test string every time +>> or deconstruct the term string every time. I could move the "T" +>> prefix string to a #define and use that both here and in +>> BOOLEAN_PREFIX_INTERNAL, but that solution may be worse than the +>> problem. What do you think? +> +> Maybe just a comment to point to BOOLEAN_PREFIX_INTERNAL. +> +> Or maybe define a macro right beside BOOLEAN_PREFIX_INTERNAL like +> +> #define ADD_TYPE_PREFIX(s) "T" s +> +> At least then the duplication is all in one place. + +A #define by BOOLEAN_PREFIX_INTERNAL won't help because +BOOLEAN_PREFIX_INTERNAL lives in database.cc and this code is in +message.cc. I would have to put the #define in one of the private +headers, but I could use it in BOOLEAN_PREFIX_INTERNAL so there wouldn't +be any duplication of the "T" string. + +I added a comment pointing to BOOLEAN_PREFIX_INTERNAL. Maybe that's +enough? + +I'll post v2 later today, when I can run the test suite (currently +running on battery). -- 2.26.2