From 1fac06b78e51df14b2a2926208e08382e0bad462 Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Sun, 12 Jan 2014 19:05:11 +0200 Subject: [PATCH] Re: [PATCH] notmuch: Add "maildir:" search option --- ea/301bc5cfd4cbc33535f241824c69410ff5d3cd | 95 +++++++++++++++++++++++ 1 file changed, 95 insertions(+) create mode 100644 ea/301bc5cfd4cbc33535f241824c69410ff5d3cd diff --git a/ea/301bc5cfd4cbc33535f241824c69410ff5d3cd b/ea/301bc5cfd4cbc33535f241824c69410ff5d3cd new file mode 100644 index 000000000..59b21fdfc --- /dev/null +++ b/ea/301bc5cfd4cbc33535f241824c69410ff5d3cd @@ -0,0 +1,95 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 43B4D429E31 + for ; Sun, 12 Jan 2014 09:05:25 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 2Xxndsb9rwcV for ; + Sun, 12 Jan 2014 09:05:15 -0800 (PST) +Received: from mail-ea0-f175.google.com (mail-ea0-f175.google.com + [209.85.215.175]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 0814A429E2F + for ; Sun, 12 Jan 2014 09:05:14 -0800 (PST) +Received: by mail-ea0-f175.google.com with SMTP id z10so2903489ead.34 + for ; Sun, 12 Jan 2014 09:05:13 -0800 (PST) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:cc:subject:in-reply-to:references + :user-agent:date:message-id:mime-version:content-type; + bh=mzX1IpkH7uc1Yc4HWRtyJg73nlvkS4L+iXrElKTnZLw=; + b=fRgVXejfuqryCKYJZcqmGpVY3zRZEC9mVdfkxSfhLiykbdvaNzIcwYF+JEcCwlgSsl + FQddrIwyQcl88tHJuJt8ixxLNyiXp/zQ/IRPNgb/4LLs5AoxdGx+hj5pseQlVeB9SiCd + g/2sH3+0h5a3+/+JJjP9yN4fP6Ja0n8Uwrx7snc5Iriyqy8yLEtJp87XAemHoZjajmzg + ZAUbRVE89BF1GUGLKVqdH7gWEVUqOzf3Wx8Vp+8/kmyrzaVFuKg2V+SJt4D99nrpGLRt + fmdPSEDoii2+8jGidDLkH9J4PV6XFLjGJE+4jdlisJ8K+iZL2g8H6jm2/jwOwiAcbylx + 0FYA== +X-Gm-Message-State: + ALoCoQlWcfbjj/s9uPQg0IwgmUhKIuhyBr3rqKG8Ad3N+o9AeXo9rs/OE6Bk5OKEaOrKw+tABlv+ +X-Received: by 10.14.220.136 with SMTP id o8mr10277890eep.97.1389546313805; + Sun, 12 Jan 2014 09:05:13 -0800 (PST) +Received: from localhost (dsl-hkibrasgw2-58c36f-91.dhcp.inet.fi. + [88.195.111.91]) + by mx.google.com with ESMTPSA id 7sm32499133eee.12.2014.01.12.09.05.12 + for + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Sun, 12 Jan 2014 09:05:13 -0800 (PST) +From: Jani Nikula +To: Peter Zijlstra +Subject: Re: [PATCH] notmuch: Add "maildir:" search option +In-Reply-To: <20140112160619.GM7572@laptop.programming.kicks-ass.net> +References: <20131112155637.GA16796@laptop.programming.kicks-ass.net> + <8761ppurfz.fsf@nikula.org> + <20140112160619.GM7572@laptop.programming.kicks-ass.net> +User-Agent: Notmuch/0.17~rc2+18~g39a67a6 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 12 Jan 2014 19:05:11 +0200 +Message-ID: <8738ktuo54.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 12 Jan 2014 17:05:25 -0000 + +On Sun, 12 Jan 2014, Peter Zijlstra wrote: +> Right, sorry for disappearing; I failed to find time to finish the +> patch. + +That's what I figured, but didn't want to pester you... + +> I did actually modify it do loose the /new,/cur bits and I think I +> addressed all other comments, including the file removal part. +> +> Where I got 'stuck' was writing test cases. + +Yeah, that can be a pain, but pretty much a mandatory one. Me mucking +with the "folder:" prefix also requires doing the database upgrade. + +> Anyway, I'll try and have a look at the recent notmuch.git and see if it +> does what I'd like it to. + +It's currently just patches, awaiting review, but the idea of modifying +the "folder:" prefix was met with approval, at least on IRC. + +BR, +Jani. + -- 2.26.2