From 1f2c874296b05c738b0efcd609887199916a1873 Mon Sep 17 00:00:00 2001 From: Robert Bradshaw Date: Thu, 13 Aug 2009 01:12:44 -0700 Subject: [PATCH] More explicit TODOs. --- Cython/Compiler/ExprNodes.py | 2 +- Cython/Compiler/PyrexTypes.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Cython/Compiler/ExprNodes.py b/Cython/Compiler/ExprNodes.py index 2098e05e..d28cf922 100755 --- a/Cython/Compiler/ExprNodes.py +++ b/Cython/Compiler/ExprNodes.py @@ -3928,7 +3928,7 @@ class UnopNode(ExprNode): "++": u"__inc__", "--": u"__dec__", "*": u"__deref__", - "!": u"__not__" + "!": u"__not__" # TODO(danilo): Also handle in NotNode. } diff --git a/Cython/Compiler/PyrexTypes.py b/Cython/Compiler/PyrexTypes.py index ba521a30..b4b64726 100755 --- a/Cython/Compiler/PyrexTypes.py +++ b/Cython/Compiler/PyrexTypes.py @@ -109,6 +109,7 @@ class PyrexType(BaseType): return self def specialize(self, values): + # TODO(danilo): Override wherever it makes sense. return self def literal_code(self, value): @@ -1396,7 +1397,6 @@ class CppClassType(CType): self.template_type = template_type def specialize_here(self, pos, template_values = None): - # TODO: cache for efficiency if self.templates is None: error(pos, "'%s' type is not a template" % self); return PyrexTypes.error_type @@ -1407,7 +1407,7 @@ class CppClassType(CType): return self.specialize(dict(zip(self.templates, template_values))) def specialize(self, values): - # TODO: cache for efficiency + # TODO(danilo): Cache for efficiency. template_values = [t.specialize(values) for t in self.templates] return CppClassType(self.name, self.scope.specialize(values), self.cname, self.base_classes, template_values, template_type=self) @@ -1425,7 +1425,7 @@ class CppClassType(CType): return "%s %s%s" % (name, entity_code, templates) def is_subclass(self, other_type): - # TODO: handle templates + # TODO(danilo): Handle templates. if self.same_as_resolved_type(other_type): return 1 for base_class in self.base_classes: -- 2.26.2