From 1ee9b0739bde500e429e39ec59c6a1ad445a3a4d Mon Sep 17 00:00:00 2001
From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Wed, 27 Apr 2016 21:14:12 +0300
Subject: [PATCH] Re: [PATCH 0/4] configure: fix some shellcheck warnings

---
 e8/d65b3a9d3a2972a9e1d3c73b4ac704a3f785c7 | 99 +++++++++++++++++++++++
 1 file changed, 99 insertions(+)
 create mode 100644 e8/d65b3a9d3a2972a9e1d3c73b4ac704a3f785c7

diff --git a/e8/d65b3a9d3a2972a9e1d3c73b4ac704a3f785c7 b/e8/d65b3a9d3a2972a9e1d3c73b4ac704a3f785c7
new file mode 100644
index 000000000..9e59a9d28
--- /dev/null
+++ b/e8/d65b3a9d3a2972a9e1d3c73b4ac704a3f785c7
@@ -0,0 +1,99 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id 5531A6DE024A
+ for <notmuch@notmuchmail.org>; Wed, 27 Apr 2016 11:14:25 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: 0.608
+X-Spam-Level: 
+X-Spam-Status: No, score=0.608 tagged_above=-999 required=5 tests=[AWL=-0.044,
+  SPF_NEUTRAL=0.652] autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id RZdCQp69-wb1 for <notmuch@notmuchmail.org>;
+ Wed, 27 Apr 2016 11:14:17 -0700 (PDT)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+ by arlo.cworth.org (Postfix) with ESMTP id 1AECD6DE01D0
+ for <notmuch@notmuchmail.org>; Wed, 27 Apr 2016 11:14:17 -0700 (PDT)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+ by guru.guru-group.fi (Postfix) with ESMTP id E571E100063;
+ Wed, 27 Apr 2016 21:14:12 +0300 (EEST)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
+Subject: Re: [PATCH 0/4] configure: fix some shellcheck warnings
+In-Reply-To: <cover.1460572142.git.jani@nikula.org>
+References: <cover.1460572142.git.jani@nikula.org>
+User-Agent: Notmuch/0.22+7~g2ab49fe (http://notmuchmail.org) Emacs/24.3.1
+ (x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Wed, 27 Apr 2016 21:14:12 +0300
+Message-ID: <m24mamx6kr.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.20
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Wed, 27 Apr 2016 18:14:25 -0000
+
+On Wed, Apr 13 2016, Jani Nikula <jani@nikula.org> wrote:
+
+> TIL about shellcheck [1]. Played with it a bit. Seems useful.
+>
+> $ shellcheck --exclude 2086 --shell sh configure
+>
+> BR,
+> Jani.
+>
+> [1] http://www.shellcheck.net/
+>
+>
+> Jani Nikula (4):
+
+This series looks tolerable to me, with a slight change in first commit msg:
+
+>   configure: SC2006: Use $(..) instead of deprecated `..`
+
+This is what older shellcheck outputs, but newer has fixed this to be
+
+   configure: SC2006: Use $(..) instead of legacy `..`
+
+When testing in http://www.shellcheck.net/
+
+Line 1:
+foo=`echo x`
+^-- SC2034: foo appears unused. Verify it or export it.
+    ^-- SC2006: Use $(..) instead of legacy `..`.
+    ^-- SC2116: Useless echo? Instead of 'cmd $(echo foo)', just use 'cmd
+    foo'.
+
+This is the shellcheck commit (s/deprecated/legacy/ for backtick warnings.):
+
+https://github.com/koalaman/shellcheck/commit/895d83afc5f4dec7dc9813a2688c45b96d6f7b7c
+
+based on these I suggest commit message amend before pushing (?)
+
+Tomi
+
+
+>   configure: SC2059: Don't use variables in the printf format string.
+>   configure: SC2034: glib_cflags and glib_ldflags appear unused.
+>   configure: SC2016: Expressions don't expand in single quotes
+>
+>  configure | 25 +++++++++++++------------
+>  1 file changed, 13 insertions(+), 12 deletions(-)
+>
+> -- 
+> 2.1.4
-- 
2.26.2