From 1c9da46da4fe5cf99c5f6ab251419d0f412ecfba Mon Sep 17 00:00:00 2001 From: Jonas Fonseca Date: Wed, 27 Apr 2005 00:00:01 +0200 Subject: [PATCH] [PATCH] read_tree_recursive(): Fix leaks Fix two potential leaks. Signed-off-by: Jonas Fonseca Signed-off-by: Petr Baudis --- tree.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tree.c b/tree.c index a978c53a3..ca800a85f 100644 --- a/tree.c +++ b/tree.c @@ -39,14 +39,17 @@ static int read_tree_recursive(void *buffer, unsigned long size, if (S_ISDIR(mode)) { int retval; int pathlen = strlen(path); - char *newbase = xmalloc(baselen + 1 + pathlen); + char *newbase; void *eltbuf; char elttype[20]; unsigned long eltsize; eltbuf = read_sha1_file(sha1, elttype, &eltsize); - if (!eltbuf || strcmp(elttype, "tree")) + if (!eltbuf || strcmp(elttype, "tree")) { + if (eltbuf) free(eltbuf); return -1; + } + newbase = xmalloc(baselen + 1 + pathlen); memcpy(newbase, base, baselen); memcpy(newbase + baselen, path, pathlen); newbase[baselen + pathlen] = '/'; -- 2.26.2