From 1bab55562735167475a51e16f13cf334b482ccc8 Mon Sep 17 00:00:00 2001 From: David Edmondson Date: Fri, 9 May 2014 09:27:37 +0100 Subject: [PATCH] Re: [PATCH v4 0/2] emacs: show: redesign unread/read logic --- 53/ed3a53e1c5786a81c4182bc6411beb9bcecebb | 111 ++++++++++++++++++++++ 1 file changed, 111 insertions(+) create mode 100644 53/ed3a53e1c5786a81c4182bc6411beb9bcecebb diff --git a/53/ed3a53e1c5786a81c4182bc6411beb9bcecebb b/53/ed3a53e1c5786a81c4182bc6411beb9bcecebb new file mode 100644 index 000000000..4ed0216e5 --- /dev/null +++ b/53/ed3a53e1c5786a81c4182bc6411beb9bcecebb @@ -0,0 +1,111 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 93B7B431FBF + for ; Fri, 9 May 2014 01:27:52 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id sJltZjnlbeGi for ; + Fri, 9 May 2014 01:27:45 -0700 (PDT) +Received: from mail-we0-f173.google.com (mail-we0-f173.google.com + [74.125.82.173]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 07FBE431FAE + for ; Fri, 9 May 2014 01:27:44 -0700 (PDT) +Received: by mail-we0-f173.google.com with SMTP id u57so3591966wes.4 + for ; Fri, 09 May 2014 01:27:44 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:to:subject:in-reply-to:references:user-agent + :from:date:message-id:mime-version:content-type; + bh=zYUEEtncEq0ZcGA9nia+tESR4z58RI3UkwEdXTEb0mY=; + b=Yty0PxGYo1Mn1HeatCLX9Y9HFA7eDIiPMNL6d4q+3gWw0gEGRmWCFRIKhaxVJnBVxQ + BuYc1XoZhs3WmlVHN7I7GLWfXLSRFmg2Y8a8o91jzQl+CgtJ7ttX/pHzkDaki7apiQnj + ijhmA+DfjQohaBjqEi2EAMunLACt4TBtt5ZFgbvxVRd7XsB5jdsC0GFCWOL/LNmV3ftM + wuKibYqBAEDYsh7gjQcoYlpnfK4+3njKlNWu/tbAzatzo3Q4shntu84xFkEvIBHgvSH9 + CEBZ2mPaVHu8FhWwRCMyaxEs16O/hi7M1XTtqb2zbjXAc68Od4QcFqJOnA83m4iwxtE2 + IbvA== +X-Gm-Message-State: + ALoCoQl8j/E6ZYK+OONI9K8iqIkkFoqUN7ErDLIRTJsWkCZ0xWAsrVPdjYetUWt84w4bdJMxHo97 +X-Received: by 10.194.60.114 with SMTP id g18mr976372wjr.61.1399624063858; + Fri, 09 May 2014 01:27:43 -0700 (PDT) +Received: from localhost ([2a01:348:1a2:1:a288:b4ff:fe8a:77d8]) + by mx.google.com with ESMTPSA id ed6sm2511999wib.20.2014.05.09.01.27.42 + for + (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Fri, 09 May 2014 01:27:42 -0700 (PDT) +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH v4 0/2] emacs: show: redesign unread/read logic +In-Reply-To: <1399594808-2815-1-git-send-email-markwalters1009@gmail.com> +References: <1399594808-2815-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +From: David Edmondson +Date: Fri, 09 May 2014 09:27:37 +0100 +Message-ID: +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha1; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 09 May 2014 08:27:52 -0000 + +--=-=-= +Content-Type: text/plain + +On Fri, May 09 2014, Mark Walters wrote: +> This is v4 of this set. v3 is at id:1395777793-13297-1-git-send-email-markwalters1009@gmail.com +> +> David (dme) was not keen on the logic in the previous patch so I have +> tried to make it rather more customisable and made this version much +> closer to the existing logic. +> +> This version marks the current message read if it is open. It doesn't +> care how you get there: whether it is notmuch commands n/N/p/P next +> message etc, emacs commands like scroll up, mouse clicks etc. +> +> The only proviso is it will only mark a message read once (in a single +> buffer and between refreshes) as otherwise it is impossible for a user +> to choose to mark a message unread. + +This version looks good to me, thanks for considering the feedback. + +> I, personally, like my previous logic much more. But with this setup +> that can be customized easily in my .emacs (we may choose to add other +> options into mainline later). Also I think this series fixes all of +> the problems with the current read/unread logic mentioned in +> id:87a9atmpkf.fsf@qmul.ac.uk are fixed. + +Just to confirm: you can get your desired behaviour by writing an +alternative `notmuch-show-mark-read-function'? + +--=-=-= +Content-Type: application/pgp-signature; name="signature.asc" + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1 + +iKYEARECAGYFAlNskXlfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl +bnBncC5maWZ0aGhvcnNlbWFuLm5ldDc1M0Y5NDJDMEExNjc3MDE4OURGMUYyMDY5 +RUNEMEFCRjA0OTY1MTYACgkQaezQq/BJZRYnCwCfWEi7v4IeT9aPVR8zrXJRdtL8 +RaYAnR6j52X/sbJrDWzxdTW/alFB8XuR +=ggm/ +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2