From 1baa672998d5b72418954fbd86e6e438c03f3218 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Sun, 2 Feb 2014 18:15:09 +0000 Subject: [PATCH] Re: [PATCH v2 0/7] lib: replace the message header parser with gmime --- 3a/b571a18e9ce71b2fe5e76eb4a2c0331b799bac | 127 ++++++++++++++++++++++ 1 file changed, 127 insertions(+) create mode 100644 3a/b571a18e9ce71b2fe5e76eb4a2c0331b799bac diff --git a/3a/b571a18e9ce71b2fe5e76eb4a2c0331b799bac b/3a/b571a18e9ce71b2fe5e76eb4a2c0331b799bac new file mode 100644 index 000000000..290e5f492 --- /dev/null +++ b/3a/b571a18e9ce71b2fe5e76eb4a2c0331b799bac @@ -0,0 +1,127 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 201C3431FBD + for ; Sun, 2 Feb 2014 10:17:59 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id UoK9remFvk4c for ; + Sun, 2 Feb 2014 10:17:51 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id D1723431FBC + for ; Sun, 2 Feb 2014 10:17:50 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1WA1bn-0000Yx-Ab; Sun, 02 Feb 2014 18:17:45 +0000 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1WA1at-0004S4-VN; Sun, 02 Feb 2014 18:16:36 +0000 +From: Mark Walters +To: Jani Nikula , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 0/7] lib: replace the message header parser with gmime +In-Reply-To: +References: +User-Agent: Notmuch/0.15.2+484~gfb59956 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Sun, 02 Feb 2014 18:15:09 +0000 +Message-ID: <874n4hqt3m.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-Geographic: According to ripencc, + this message was delivered by a machine in Britain (UK) (GB). +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 6390360279f6ef9f4bb0e51df55b868d (of first 20000 bytes) +X-SpamAssassin-Score: 0.0 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored 0.0 points. Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * 0.0 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 02 Feb 2014 18:17:59 -0000 + + +Patches 1-4 basically LGTM but patch 1 needs to be rebased since all the +tests were renamed. I have a couple of minor comments on patches 2 and 3 +that I will send separately. + +Best wishes + +Mark + + +On Sat, 30 Nov 2013, Jani Nikula wrote: +> This is v2 of id:cover.1381948853.git.jani@nikula.org with more polish. +> +> Patches 1-4 do prep work to fix some of the differences in the parsers +> in advance. Arguably they are not that bad regardless of the parser +> change. +> +> Patches 5-6 actually make the change. Having two patches is a somewhat +> artificial division, but perhaps makes it easier to review. +> +> Patch 7 is just a hack to make perf tests not ignore so many mails... we +> have quite a bit of non-emails in the corpus by gmime parser +> standards. And this illustrates one of the differences in the parsers. +> +> +> BR, +> Jani. +> +> Jani Nikula (7): +> cli: sanitize tabs and newlines to spaces in notmuch search +> cli: refactor reply from guessing +> util: make sanitize string available in string util for reuse +> cli: sanitize the received header before scanning for replies +> lib: replace the header parser with gmime +> lib: parse messages only once +> HACK: fix broken messages in the perf test corpus +> +> lib/database.cc | 6 +- +> lib/index.cc | 70 +------- +> lib/message-file.c | 351 +++++++++++++------------------------- +> lib/message.cc | 6 + +> lib/notmuch-private.h | 20 ++- +> notmuch-reply.c | 186 ++++++++++++-------- +> notmuch-search.c | 17 -- +> performance-test/perf-test-lib.sh | 4 + +> test/search-output | 2 +- +> util/string-util.c | 22 +++ +> util/string-util.h | 7 + +> 11 files changed, 297 insertions(+), 394 deletions(-) +> +> -- +> 1.8.4.2 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2