From 1a34ed58933a45f5685efca08ad54e5372e0f76a Mon Sep 17 00:00:00 2001 From: David Edmondson Date: Thu, 8 May 2014 07:14:23 +0100 Subject: [PATCH] Re: [Patch v3 0/3] emacs: show: redesign unread/read logic --- 45/5bb14696d1e8bf610c89897e12fe5d65edce5d | 159 ++++++++++++++++++++++ 1 file changed, 159 insertions(+) create mode 100644 45/5bb14696d1e8bf610c89897e12fe5d65edce5d diff --git a/45/5bb14696d1e8bf610c89897e12fe5d65edce5d b/45/5bb14696d1e8bf610c89897e12fe5d65edce5d new file mode 100644 index 000000000..945417567 --- /dev/null +++ b/45/5bb14696d1e8bf610c89897e12fe5d65edce5d @@ -0,0 +1,159 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1F673431FBF + for ; Wed, 7 May 2014 23:14:38 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 0rYr7oF7fXW3 for ; + Wed, 7 May 2014 23:14:34 -0700 (PDT) +Received: from mail-we0-f175.google.com (mail-we0-f175.google.com + [74.125.82.175]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 1CBF8431FAE + for ; Wed, 7 May 2014 23:14:33 -0700 (PDT) +Received: by mail-we0-f175.google.com with SMTP id t61so1984775wes.6 + for ; Wed, 07 May 2014 23:14:30 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:to:subject:in-reply-to:references:user-agent + :from:date:message-id:mime-version:content-type; + bh=MiaOphia8LdyFQizMy5X0RqBXG7JMUB16NNScF1KlXw=; + b=jUWP+dCDLg/WRLX7tEC6bI7uc8o6twSHBsPvAbv606tpgWf/d1WAy7nS+mDS5DK/hF + Q3/zRYAMp2j1IFMDP0tSssPOCv9g/LvpCDS0U/9MPk6YscLv/sY2sb8y8PS+AJJtzBRV + gOa7VOpSk4mZwAkxYVi4Exxkp8JOL2NqAHErzO/bm9p6w94jCHlp0O7G23OSy/h3yRrC + f+3vvbfACO9acXzdvR1ZZCGFFfTziFFYSfOfeeQmBj0mX43DFg4+Y63IwLWjL72x1p61 + Pu5f1msundDT6tE8JZFuIZ2pQ9+CH76LVIdA+cryCAMqVNVqdPEa9Fbn89mYFZbP+Nj3 + 5IXg== +X-Gm-Message-State: + ALoCoQlNJ5q5rlJ1Q4Np3FfTZncyOiaVhWRrEHT7w2BTNg2+fqsRq35xc4xEHR03wbqMbjCcbL9Y +X-Received: by 10.194.200.199 with SMTP id ju7mr51041wjc.77.1399529670523; + Wed, 07 May 2014 23:14:30 -0700 (PDT) +Received: from localhost (disaster-area.hh.sledj.net. [81.149.164.25]) + by mx.google.com with ESMTPSA id pl6sm29895wjc.0.2014.05.07.23.14.28 + for + (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Wed, 07 May 2014 23:14:29 -0700 (PDT) +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [Patch v3 0/3] emacs: show: redesign unread/read logic +In-Reply-To: <87a9atmpkf.fsf@qmul.ac.uk> +References: <1395777793-13297-1-git-send-email-markwalters1009@gmail.com> + + <87a9atmpkf.fsf@qmul.ac.uk> +User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +From: David Edmondson +Date: Thu, 08 May 2014 07:14:23 +0100 +Message-ID: +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha1; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 08 May 2014 06:14:38 -0000 + +--=-=-= +Content-Type: text/plain +Content-Transfer-Encoding: quoted-printable + +On Wed, May 07 2014, Mark Walters wrote: +> A message is marked read if: +> +> 1) if you navigate to a message using n/p (next/prev open message)=20 +> +> 2) if you navigate to it using N/P (next/prev message) regardless of +> whether the message is open or closed. +> +> 3) if you go to it using n.s.next-matching-message (not bound by +> default) whether message is open or closed. +> +> 4) when you enter a buffer and notmuch goes to the first open message. +> +> but not marked read in cases like: +> +> 1) opening a message +> +> 2) viewing or entering a message using other notmuch navigation such as +> notmuch-show-advance and friends (bound to space) + +My experience is that this removes the 'unread' tag. + +> 3) viewing or entering a message using arrow keys, page-up page-down, +> ctrl-v mouse clicks etc +> +> Personally, I think marking a closed message read is a bug, + +Agreed. + +> and not marking it read when opening it is too + +Agreed. + +> (at least in many cases). + +I would be happy with just these fixed (i.e. the current behaviour with +those two bug fixes). My typical use is to move around a thread using +Space, Backspace, n, p, N and P with RET, M-RET and C-u M-RET to +manipulate open/closed state (i.e. not the normal emacs movement +commands to move). + +> The other problem with the current approach (in my view) is that if +> you try to use the navigation commands non-interactively then messages +> end up being marked read, even if they are never displayed to the +> user. + +In what cases does this happen? (Not arguing, just not fully +understanding.) + +> Linking into the post-command-hook means that this should "just work". +> +> Questions: What does it mean for a message to be the current message? +> Is it just point being in the message? + +This makes sense to me, other than perhaps "point being in an _open_ +message". I don't want moving point through a closed message with C-n to +remove the 'unread' tag. + +> Would you be happy with a message being marked read when point entered +> the message? That could be done from the post-command-hook +> infrastructure to fix some of the problems mentioned above. +> +> I think that is likely that people will disagree on how they want this +> to work so I would like to try and make it customisable so I would +> definitely be interested to see if I can get the behaviour you would +> like from this infrastructure (or something similar). +> +> Best wishes +> +> Mark + +--=-=-= +Content-Type: application/pgp-signature; name="signature.asc" + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1 + +iKYEARECAGYFAlNrIL9fFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl +bnBncC5maWZ0aGhvcnNlbWFuLm5ldDc1M0Y5NDJDMEExNjc3MDE4OURGMUYyMDY5 +RUNEMEFCRjA0OTY1MTYACgkQaezQq/BJZRY2PQCdHFWkCIz2LtQU3y8G0Vuq0e0G +B44An2FYcBf9P0TMrpkMCdNYEIueSnop +=J8Kd +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2