From 192c766d897a5a28ce9ba9fe29b7ef0e587ee0d4 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Sat, 27 Apr 2013 12:39:17 +0300 Subject: [PATCH] Re: [PATCH 1/1] emacs: fixed (declare-function ...) definitions --- 92/59a54e14b7e6e32901a05c38f1d227a929447b | 79 +++++++++++++++++++++++ 1 file changed, 79 insertions(+) create mode 100644 92/59a54e14b7e6e32901a05c38f1d227a929447b diff --git a/92/59a54e14b7e6e32901a05c38f1d227a929447b b/92/59a54e14b7e6e32901a05c38f1d227a929447b new file mode 100644 index 000000000..fd1a91c00 --- /dev/null +++ b/92/59a54e14b7e6e32901a05c38f1d227a929447b @@ -0,0 +1,79 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 3B2A3431FBD + for ; Sat, 27 Apr 2013 02:39:19 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id X9c7nBN3Ylz3 for ; + Sat, 27 Apr 2013 02:39:18 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 9668D431FAF + for ; Sat, 27 Apr 2013 02:39:18 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 929FA1001F0; + Sat, 27 Apr 2013 12:39:17 +0300 (EEST) +From: Tomi Ollila +To: David Bremner , + Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH 1/1] emacs: fixed (declare-function ...) definitions +In-Reply-To: <87mwt2ve95.fsf@zancas.localnet> +References: <1365630175-1048-1-git-send-email-tomi.ollila@iki.fi> + <87eheekjgp.fsf@qmul.ac.uk> <87mwt2ve95.fsf@zancas.localnet> +User-Agent: Notmuch/0.15.2+75~gd7fa7c4 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 27 Apr 2013 09:39:19 -0000 + +On Sat, Apr 13 2013, David Bremner wrote: + +> Mark Walters writes: +> +>> On Wed, 10 Apr 2013, Tomi Ollila wrote: +>>> Some (declare-function ...) definitions were drifted away from the +>>> actual (defun ...)'s. To find the drifts and to verify changes +>>> the following command line was used: +>>> +>>> $ emacs --batch -L emacs --eval '(check-declare-directory "emacs")' +>> +>> This patch looks good to me +1. +>> +>> Is it worth making the above command into a test? + +I attempted to do a test -- failed miserably with test_emacs () + +> Maybe a release check? + +You want to delegate the work developers should do to yourself +(if not fixing the things, moan about those ;) + +For the time being I drop needs-review tag. + +> d + +Tomi -- 2.26.2