From 18b2e5221e5c9b611e3fdffd7c355533281fb57d Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Fri, 10 Jun 2016 14:11:43 +0300 Subject: [PATCH] Re: [PATCH] WIP: regexp matching in 'subject' and 'from' --- 78/c8afd550c7a212d2fcddc63dfc4e1ab5a0cf82 | 73 +++++++++++++++++++++++ 1 file changed, 73 insertions(+) create mode 100644 78/c8afd550c7a212d2fcddc63dfc4e1ab5a0cf82 diff --git a/78/c8afd550c7a212d2fcddc63dfc4e1ab5a0cf82 b/78/c8afd550c7a212d2fcddc63dfc4e1ab5a0cf82 new file mode 100644 index 000000000..9000d356b --- /dev/null +++ b/78/c8afd550c7a212d2fcddc63dfc4e1ab5a0cf82 @@ -0,0 +1,73 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 6C45F6DE0222 + for ; Fri, 10 Jun 2016 04:12:06 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.571 +X-Spam-Level: +X-Spam-Status: No, score=0.571 tagged_above=-999 required=5 tests=[AWL=-0.081, + SPF_NEUTRAL=0.652] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id SES7IQoqj5i8 for ; + Fri, 10 Jun 2016 04:11:58 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by arlo.cworth.org (Postfix) with ESMTP id 19FA96DE0130 + for ; Fri, 10 Jun 2016 04:11:58 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 6DD82100104; + Fri, 10 Jun 2016 14:11:43 +0300 (EEST) +From: Tomi Ollila +To: David Bremner , notmuch +Subject: Re: [PATCH] WIP: regexp matching in 'subject' and 'from' +In-Reply-To: <87d1npydc2.fsf@zancas.localnet> +References: <1465265149-7174-1-git-send-email-david@tethera.net> + <1465525688-30913-1-git-send-email-david@tethera.net> + <87d1npydc2.fsf@zancas.localnet> +User-Agent: Notmuch/0.22+32~gd4854c5 (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 10 Jun 2016 11:12:06 -0000 + +On Fri, Jun 10 2016, David Bremner wrote: + +> David Bremner writes: +> +>> +#ifdef HAVE_XAPIAN_FIELD_PROCESSOR +>> + delete notmuch->from_re_field_processor; +>> + notmuch->from_re_field_processor = NULL; +>> + delete notmuch->subject_re_field_processor; +>> + notmuch->subject_re_field_processor = NULL; +>> +#endif +> +> and of course everywhere it says #ifdef HAVE_XAPIAN_FIELD_PROCESSOR, is +> should say #if. + +... is there a static code analyzer which notices such a mistakes... ? + +i did marked that version trivial, which completes the thought that there +are no such thing as trivial changes ;/ + + +> d -- 2.26.2