From 17f12763db2c14f92f56bcd6e194412d0c4c9a89 Mon Sep 17 00:00:00 2001 From: "https://www.google.com/accounts/o8/id?id=AItOawmUWmB1M35_jviFvGPYDIH-a-_Al-7OrXM" Date: Fri, 15 Jul 2011 20:54:09 -0400 Subject: [PATCH] Fixed presentation issue for "RecentChanges" to emulate git.pm. All lifted issues have been looked at now, so I (try to) tag the page as "patch". --- doc/todo/Attempt_to_extend_Mercurial_backend_support.mdwn | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/doc/todo/Attempt_to_extend_Mercurial_backend_support.mdwn b/doc/todo/Attempt_to_extend_Mercurial_backend_support.mdwn index 868b57a17..b17960385 100644 --- a/doc/todo/Attempt_to_extend_Mercurial_backend_support.mdwn +++ b/doc/todo/Attempt_to_extend_Mercurial_backend_support.mdwn @@ -22,6 +22,12 @@ Diff follows, for anyone to annotate. First code version is also available at [m > I've looked over the current version and it looks ok to me. --[[Joey]] +>> I changed the by `mercurial.pm` recorded commit messages and the `rcs_recentchanges` logic to include more information, to emulate the `git.pm` behaviour regarding name presentation on RecentChanges. I don't have anything more to add at the moment, so if the code passes review, I'm done, and I tag this page as "patch". [Final patch version as per this page at my hg repo](http://510x.se/hg/program/ikiwiki/file/bc0e2f838fe3/Plugin/mercurial.pm) ([raw format](http://46.239.104.5:81/hg/program/ikiwiki/raw-file/bc0e2f838fe3/Plugin/mercurial.pm)). I keep the below conversation for reference, but it's mostly outdated. --[[Daniel Andersson]] + +[[!tag patch]] + +*** + diff -r 20c61288d7bd Plugin/mercurial.pm --- a/Plugin/mercurial.pm Fri Jul 15 02:55:12 2011 +0200 +++ b/Plugin/mercurial.pm Fri Jul 15 03:29:10 2011 +0200 @@ -166,6 +172,8 @@ Some old `mercurial.pm` logic concerning commiter name is kept instead of transp >> Yes, right now the long and ugly OpenID strings, e.g. `https://www.google.com/accounts/o8/id?id=AItOawmUIes3yDLfQME0uvZvJKDN0NsdKPx_PTw`, gets recorded as author and are shown as `id [www.google.com/accounts/o8]` in RecentChanges. I see that here on `ikiwiki.info`, my commits, identified by OpenID, are shown as authored by simply `Daniel`. I'll look into it. --[[Daniel Andersson]] +>>> I adapted some logic from `git.pm`. `hg` only has a single commiter name field, whereas `git` has both `GIT_AUTHOR_NAME` and `GIT_AUTHOR_EMAIL`. The behaviour can be emulated by encoding nick and commit medium into commiter name as "`https://www.google.com/accounts/o8/id?id=AItOawmUIes3yDLfQME0uvZvJKDN0NsdKPx_PTw `" and parsing this out as necessary when `rcs_recentchanges` is called. *Done* --[[Daniel Andersson]] + @@ -143,43 +206,45 @@ $params{message} = "no message given"; } -- 2.26.2