From 17d8fc40cebb9e71d690dcc04633d545a17db024 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Sun, 15 Sep 2013 15:35:04 +0100 Subject: [PATCH] [PATCH 1/3] contrib: pick: remove some superfluous quotes --- aa/a102b98808de2a4606f414b5e92775fbf99f4f | 98 +++++++++++++++++++++++ 1 file changed, 98 insertions(+) create mode 100644 aa/a102b98808de2a4606f414b5e92775fbf99f4f diff --git a/aa/a102b98808de2a4606f414b5e92775fbf99f4f b/aa/a102b98808de2a4606f414b5e92775fbf99f4f new file mode 100644 index 000000000..ce114feff --- /dev/null +++ b/aa/a102b98808de2a4606f414b5e92775fbf99f4f @@ -0,0 +1,98 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 35EEA431FD0 + for ; Sun, 15 Sep 2013 07:35:21 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.201 +X-Spam-Level: +X-Spam-Status: No, score=0.201 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001, + RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id TnEwAVVJrUqB for ; + Sun, 15 Sep 2013 07:35:15 -0700 (PDT) +Received: from mail-we0-f172.google.com (mail-we0-f172.google.com + [74.125.82.172]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 88504431FAF + for ; Sun, 15 Sep 2013 07:35:15 -0700 (PDT) +Received: by mail-we0-f172.google.com with SMTP id w61so2786680wes.3 + for ; Sun, 15 Sep 2013 07:35:13 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:cc:subject:date:message-id:in-reply-to:references; + bh=LLqbD1azLSxuwyBZ9mmu9kjw9q2hM46NDD5C/aZWhq4=; + b=YPAOCQtKpkC9Nhn5xvxC+kw+F1gwYNzpA0oIOTn3TaeF+AenfNZk3wzcNnbE5Y5P1k + d1nMu7irSUMwrBDtmIGrgsKp7reEoXtFuSzuhkS8cMDciBBBXii5TRXha/GImsXwWFZh + K3YuTybKv4djX6nCSIZrr3suovbwK5OGeq/ALirHm60WJbTubFkY6MrIfzgPIjsghblE + M0r8mfUFB4Ks/Jrmhqo1D/tm/4prThKaYNcDTlc37ezuvK0RoOfbMueHZWAK2i5mwmPC + xtAfkof8jBnHYnBW6RQMndIJszqSzXYd7xKrxwlgfiB54fyFoqw8PW38XV71DC4zegBc + /erA== +X-Received: by 10.180.189.132 with SMTP id gi4mr9827061wic.19.1379255713142; + Sun, 15 Sep 2013 07:35:13 -0700 (PDT) +Received: from localhost (93-97-24-31.zone5.bethere.co.uk. [93.97.24.31]) + by mx.google.com with ESMTPSA id e1sm16874406wij.6.1969.12.31.16.00.00 + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Sun, 15 Sep 2013 07:35:12 -0700 (PDT) +From: Mark Walters +To: notmuch@notmuchmail.org +Subject: [PATCH 1/3] contrib: pick: remove some superfluous quotes +Date: Sun, 15 Sep 2013 15:35:04 +0100 +Message-Id: <1379255706-2418-2-git-send-email-markwalters1009@gmail.com> +X-Mailer: git-send-email 1.7.9.1 +In-Reply-To: <1379255706-2418-1-git-send-email-markwalters1009@gmail.com> +References: <1379255706-2418-1-git-send-email-markwalters1009@gmail.com> +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 15 Sep 2013 14:35:21 -0000 + +Pick adds some keybindings to keymaps for other modes (for entry to +pick). These quoted the keymaps which appears to be unnecessary and to +rely on the fact that these keymaps have the same entry in the +function cell as the value cell (perhaps for historical reasons?) + +Remove these quotes. +--- + contrib/notmuch-pick/notmuch-pick.el | 12 ++++++------ + 1 files changed, 6 insertions(+), 6 deletions(-) + +diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el +index ad85d03..2deee42 100644 +--- a/contrib/notmuch-pick/notmuch-pick.el ++++ b/contrib/notmuch-pick/notmuch-pick.el +@@ -966,12 +966,12 @@ The arguments are: + + + ;; Set up key bindings from the rest of notmuch. +-(define-key 'notmuch-search-mode-map "z" 'notmuch-pick) +-(define-key 'notmuch-search-mode-map "Z" 'notmuch-pick-from-search-current-query) +-(define-key 'notmuch-search-mode-map (kbd "M-RET") 'notmuch-pick-from-search-thread) +-(define-key 'notmuch-hello-mode-map "z" 'notmuch-pick-from-hello) +-(define-key 'notmuch-show-mode-map "z" 'notmuch-pick) +-(define-key 'notmuch-show-mode-map "Z" 'notmuch-pick-from-show-current-query) ++(define-key notmuch-search-mode-map "z" 'notmuch-pick) ++(define-key notmuch-search-mode-map "Z" 'notmuch-pick-from-search-current-query) ++(define-key notmuch-search-mode-map (kbd "M-RET") 'notmuch-pick-from-search-thread) ++(define-key notmuch-hello-mode-map "z" 'notmuch-pick-from-hello) ++(define-key notmuch-show-mode-map "z" 'notmuch-pick) ++(define-key notmuch-show-mode-map "Z" 'notmuch-pick-from-show-current-query) + (notmuch-pick-setup-show-out) + (message "Initialised notmuch-pick") + +-- +1.7.9.1 + -- 2.26.2