From 176a33542eddc6e319bfef4ca726813ce0b9af55 Mon Sep 17 00:00:00 2001 From: Bobby Powers Date: Wed, 16 May 2012 10:50:31 -0400 Subject: [PATCH] diff --no-index: don't leak buffers in queue_diff MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit queue_diff uses two strbufs, and at the end of the function strbuf_reset was called. This only reset the length of the buffer - any allocated memory was leaked. Using strbuf_release fixes this. Signed-off-by: Bobby Powers Reviewed-by: René Scharfe Signed-off-by: Junio C Hamano --- diff-no-index.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/diff-no-index.c b/diff-no-index.c index 3080b663b..f0b0010ae 100644 --- a/diff-no-index.c +++ b/diff-no-index.c @@ -123,8 +123,8 @@ static int queue_diff(struct diff_options *o, } string_list_clear(&p1, 0); string_list_clear(&p2, 0); - strbuf_reset(&buffer1); - strbuf_reset(&buffer2); + strbuf_release(&buffer1); + strbuf_release(&buffer2); return ret; } else { -- 2.26.2