From 16b42e47ba72915287ebbe08ee306e3490ac3ffe Mon Sep 17 00:00:00 2001 From: David Bremner Date: Fri, 15 Nov 2013 12:11:44 +2000 Subject: [PATCH] Re: [PATCH v2 5/5] compact: provide user more information on after-compaction failures --- d5/919c06a3334c5746c896ffce10b9e14a458e2c | 76 +++++++++++++++++++++++ 1 file changed, 76 insertions(+) create mode 100644 d5/919c06a3334c5746c896ffce10b9e14a458e2c diff --git a/d5/919c06a3334c5746c896ffce10b9e14a458e2c b/d5/919c06a3334c5746c896ffce10b9e14a458e2c new file mode 100644 index 000000000..716d80b36 --- /dev/null +++ b/d5/919c06a3334c5746c896ffce10b9e14a458e2c @@ -0,0 +1,76 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 133BF431FC0 + for ; Thu, 14 Nov 2013 08:12:04 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id NSzw2I2cKMFz for ; + Thu, 14 Nov 2013 08:11:56 -0800 (PST) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 0B0C7431FB6 + for ; Thu, 14 Nov 2013 08:11:56 -0800 (PST) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1VgzWG-0004pe-6a; Thu, 14 Nov 2013 12:11:48 -0400 +Received: (nullmailer pid 32333 invoked by uid 1000); Thu, 14 Nov 2013 + 16:11:44 -0000 +From: David Bremner +To: Jani Nikula , Tomi Ollila , + notmuch@notmuchmail.org +Subject: Re: [PATCH v2 5/5] compact: provide user more information on + after-compaction failures +In-Reply-To: <871u2jnkai.fsf@nikula.org> +References: <1384362167-12740-1-git-send-email-tomi.ollila@iki.fi> + <1384362167-12740-6-git-send-email-tomi.ollila@iki.fi> + <871u2jnkai.fsf@nikula.org> +User-Agent: Notmuch/0.16+164~gfcbf06a (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Thu, 14 Nov 2013 12:11:44 -0400 +Message-ID: <87y54rx8sf.fsf@unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +Cc: tomi.ollila@iki.fi +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 14 Nov 2013 16:12:04 -0000 + +Jani Nikula writes: + +> On Wed, 13 Nov 2013, Tomi Ollila wrote: +>> After database has been compacted, there are steps to put the new +>> database into place -- and these steps may fail. In case such +>> failure happens, provide better information how to resolve it. +> +> I disagree with having a library spew all this information out. For each +> case, I think it should be sufficient to just say what happened +> (e.g. "rename a -> b failed" + strerror). I don't think a library's +> error messages should be a tutorial on how to fix things. +> + +I can live with whatever the concensus level of verbosity, but not the +fprintf's; as I mentioned, for once we have a log hook. + +That might also somewhat comfort Jani, since the library client has the +option of ignoring the spewing. + +d -- 2.26.2