From 16034fbe59e88ec9592f73523cde97714d7c727c Mon Sep 17 00:00:00 2001 From: Jeff King Date: Tue, 31 Aug 2010 11:56:36 -0400 Subject: [PATCH] tests: make test_must_fail more verbose Because test_must_fail fails when a command succeeds, the command frequently does not produce any output (since, after all, it thought it was succeeding). So let's have test_must_fail itself report that a problem occurred. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- t/test-lib.sh | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/t/test-lib.sh b/t/test-lib.sh index 3a3d4c472..285bfd894 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -591,7 +591,15 @@ test_path_is_missing () { test_must_fail () { "$@" - test $? -gt 0 -a $? -le 129 -o $? -gt 192 + exit_code=$? + if test $exit_code = 0; then + echo >&2 "test_must_fail: command succeeded: $*" + return 1 + elif test $exit_code -gt 129 -a $exit_code -le 192; then + echo >&2 "test_must_fail: died by signal: $*" + return 1 + fi + return 0 } # Similar to test_must_fail, but tolerates success, too. This is -- 2.26.2