From 1388adf193c22c7a22929743d2bb1d1ca58de9c4 Mon Sep 17 00:00:00 2001 From: John Kohl Date: Fri, 19 Apr 1991 13:53:38 +0000 Subject: [PATCH] fix up/remove XXX comments git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@2005 dc483132-0cff-0310-8789-dd5450dbe970 --- src/lib/crypto/des/cbc_cksum.c | 4 ++-- src/lib/crypto/des/des_int.h | 2 +- src/lib/crypto/des/fin_rndkey.c | 2 +- src/lib/crypto/des/init_rkey.c | 2 +- src/lib/crypto/des/process_ky.c | 6 +++--- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/lib/crypto/des/cbc_cksum.c b/src/lib/crypto/des/cbc_cksum.c index a7ce6c229..eb42d8a20 100644 --- a/src/lib/crypto/des/cbc_cksum.c +++ b/src/lib/crypto/des/cbc_cksum.c @@ -63,11 +63,11 @@ OLDDECLARG(krb5_checksum *, cksum) switch (mit_des_key_sched ((krb5_octet *)key, schedule)) { case -1: cleanup(); - return KRB5DES_BAD_KEYPAR; /* XXX error code-bad key parity */ + return KRB5DES_BAD_KEYPAR; case -2: cleanup(); - return KRB5DES_WEAK_KEY; /* XXX error code-weak key */ + return KRB5DES_WEAK_KEY; default: ; diff --git a/src/lib/crypto/des/des_int.h b/src/lib/crypto/des/des_int.h index 6f689bc83..9f39fb6f6 100644 --- a/src/lib/crypto/des/des_int.h +++ b/src/lib/crypto/des/des_int.h @@ -183,7 +183,7 @@ extern unsigned long rev_swap_bit_pos_0 PROTOTYPE((unsigned long )); extern unsigned long swap_byte_bits PROTOTYPE((unsigned long )); extern unsigned long swap_long_bytes_bit_number PROTOTYPE((unsigned long )); #ifdef FILE -/* XXX */ +/* XXX depends on FILE being a #define! */ extern void test_set PROTOTYPE((FILE *, const char *, int, const char *, int)); #endif diff --git a/src/lib/crypto/des/fin_rndkey.c b/src/lib/crypto/des/fin_rndkey.c index 089cd9c44..87f24da6a 100644 --- a/src/lib/crypto/des/fin_rndkey.c +++ b/src/lib/crypto/des/fin_rndkey.c @@ -29,5 +29,5 @@ OLDDECLARG(krb5_pointer *, seed) memset((char *)*seed, 0, sizeof(mit_des_random_key_seed) ); xfree(*seed); *seed = 0; - return 0; /* XXX init_random_key */ + return 0; } diff --git a/src/lib/crypto/des/init_rkey.c b/src/lib/crypto/des/init_rkey.c index 732265bc3..0f5d088f0 100644 --- a/src/lib/crypto/des/init_rkey.c +++ b/src/lib/crypto/des/init_rkey.c @@ -35,7 +35,7 @@ OLDDECLARG(krb5_pointer *,seed) { mit_des_random_key_seed * p_seed; if (seedblock->keytype != KEYTYPE_DES) - return KRB5_BAD_KEYTYPE; /* XXX error code bad keytype */ + return KRB5_BAD_KEYTYPE; if ( !(p_seed = (mit_des_random_key_seed *) malloc(sizeof(mit_des_random_key_seed))) ) return ENOMEM; diff --git a/src/lib/crypto/des/process_ky.c b/src/lib/crypto/des/process_ky.c index f8b41d049..0f39a4359 100644 --- a/src/lib/crypto/des/process_ky.c +++ b/src/lib/crypto/des/process_ky.c @@ -43,7 +43,7 @@ OLDDECLARG(const krb5_keyblock *,keyblock) struct mit_des_ks_struct *schedule; /* pointer to key schedules */ if (keyblock->length != sizeof (mit_des_cblock)) - return KRB5_BAD_KEYSIZE; /* XXX error code-bad key size */ + return KRB5_BAD_KEYSIZE; if ( !(schedule = (struct mit_des_ks_struct *) malloc(sizeof(mit_des_key_schedule))) ) return ENOMEM; @@ -52,11 +52,11 @@ OLDDECLARG(const krb5_keyblock *,keyblock) switch (mit_des_key_sched (keyblock->contents, schedule)) { case -1: cleanup(); - return KRB5DES_BAD_KEYPAR; /* XXX error code-bad key parity */ + return KRB5DES_BAD_KEYPAR; case -2: cleanup(); - return KRB5DES_WEAK_KEY; /* XXX error code-weak key */ + return KRB5DES_WEAK_KEY; default: eblock->key = (krb5_keyblock *) keyblock; -- 2.26.2