From 11c4caee0f2f470b8f1c7db98f6c4a164935b825 Mon Sep 17 00:00:00 2001 From: Vladimir Marek Date: Thu, 5 Sep 2013 15:20:11 +0200 Subject: [PATCH] Re: [PATCH 1/1] test: unset 'xpg_echo' bash shell option --- c8/5ffdaaa887f6cd2ca67d79bbaf42bf13cdb8ca | 105 ++++++++++++++++++++++ 1 file changed, 105 insertions(+) create mode 100644 c8/5ffdaaa887f6cd2ca67d79bbaf42bf13cdb8ca diff --git a/c8/5ffdaaa887f6cd2ca67d79bbaf42bf13cdb8ca b/c8/5ffdaaa887f6cd2ca67d79bbaf42bf13cdb8ca new file mode 100644 index 000000000..b8cf01e6d --- /dev/null +++ b/c8/5ffdaaa887f6cd2ca67d79bbaf42bf13cdb8ca @@ -0,0 +1,105 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 140EC431FDD + for ; Thu, 5 Sep 2013 06:20:32 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.299 +X-Spam-Level: +X-Spam-Status: No, score=-2.299 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3, UNPARSEABLE_RELAY=0.001] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id P1X4yzAQurxa for ; + Thu, 5 Sep 2013 06:20:26 -0700 (PDT) +Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 4CE82431FDB + for ; Thu, 5 Sep 2013 06:20:26 -0700 (PDT) +Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) + by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with + ESMTP id r85DKFM5008686 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); + Thu, 5 Sep 2013 13:20:16 GMT +Received: from userz7022.oracle.com (userz7022.oracle.com [156.151.31.86]) + by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id + r85DKEHX012939 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); + Thu, 5 Sep 2013 13:20:14 GMT +Received: from abhmt102.oracle.com (abhmt102.oracle.com [141.146.116.54]) + by userz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id + r85DKDMu012915; Thu, 5 Sep 2013 13:20:14 GMT +Received: from virt.cz.oracle.com (/10.163.102.127) + by default (Oracle Beehive Gateway v4.0) + with ESMTP ; Thu, 05 Sep 2013 06:20:13 -0700 +Date: Thu, 5 Sep 2013 15:20:11 +0200 +From: Vladimir Marek +To: Tomi Ollila +Subject: Re: [PATCH 1/1] test: unset 'xpg_echo' bash shell option +Message-ID: <20130905132011.GF19623@virt.cz.oracle.com> +References: <1377015403-12457-1-git-send-email-tomi.ollila@iki.fi> +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Disposition: inline +In-Reply-To: <1377015403-12457-1-git-send-email-tomi.ollila@iki.fi> +User-Agent: Mutt/ (2012-12-30) +X-Source-IP: ucsinet22.oracle.com [156.151.31.94] +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 05 Sep 2013 13:20:32 -0000 + +Yes, that fixes the tests on Solaris which were broken by the 'echo' +performing differently. If my vote counts, put it in, please! + +Thank you +-- + Vlad + +> When 'xpg_echo' bash shell option is unset (usually the default) +> echo builtin does not expand backslash-escape sequences by default +> (i.e. '\n' is echoed as '\n' instead of newline). Not all bash +> installations have this feature we depend on activated by default. +> +> Note that the feature is bash (and GNU /bin/echo) specific. It is used +> as it is convenient. If portability is needed (elsewhere) use printf(1) +> (also often available as a shell builtin). +> --- +> test/test-lib.sh | 3 +++ +> 1 file changed, 3 insertions(+) +> +> diff --git a/test/test-lib.sh b/test/test-lib.sh +> index ffab1bb..d3a8c58 100644 +> --- a/test/test-lib.sh +> +++ b/test/test-lib.sh +> @@ -22,6 +22,9 @@ if [ ${BASH_VERSINFO[0]} -lt 4 ]; then +> exit 1 +> fi +> +> +# Make sure echo builtin does not expand backslash-escape sequences by default. +> +shopt -u xpg_echo +> + +> # if --tee was passed, write the output not only to the terminal, but +> # additionally to the file test-results/$BASENAME.out, too. +> case "$GIT_TEST_TEE_STARTED, $* " in +> -- +> 1.8.0 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2