From 117cfdf347bb1deb39b37ef70ae6e903daa3c994 Mon Sep 17 00:00:00 2001
From: David Bremner <david@tethera.net>
Date: Sun, 28 Apr 2013 08:53:33 +2100
Subject: [PATCH] Re: [PATCH] don't store temporary value returned from c_str()

---
 4c/4a1e2ee3624e19eda1f0c700b52b5a29ab1a02 | 75 +++++++++++++++++++++++
 1 file changed, 75 insertions(+)
 create mode 100644 4c/4a1e2ee3624e19eda1f0c700b52b5a29ab1a02

diff --git a/4c/4a1e2ee3624e19eda1f0c700b52b5a29ab1a02 b/4c/4a1e2ee3624e19eda1f0c700b52b5a29ab1a02
new file mode 100644
index 000000000..207d0023a
--- /dev/null
+++ b/4c/4a1e2ee3624e19eda1f0c700b52b5a29ab1a02
@@ -0,0 +1,75 @@
+Return-Path: <bremner@unb.ca>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 9D76F431FB6
+	for <notmuch@notmuchmail.org>; Sat, 27 Apr 2013 04:53:45 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id fNDiboiXcKab for <notmuch@notmuchmail.org>;
+	Sat, 27 Apr 2013 04:53:44 -0700 (PDT)
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 20DCF431FAE
+	for <notmuch@notmuchmail.org>; Sat, 27 Apr 2013 04:53:44 -0700 (PDT)
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net
+	([156.34.82.78] helo=zancas.localnet)
+	by tesseract.cs.unb.ca with esmtpsa
+	(TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)
+	(envelope-from <bremner@unb.ca>)
+	id 1UW3hD-0002zs-Rp; Sat, 27 Apr 2013 08:53:40 -0300
+Received: from bremner by zancas.localnet with local (Exim 4.80)
+	(envelope-from <bremner@unb.ca>)
+	id 1UW3h8-00088q-4f; Sat, 27 Apr 2013 08:53:34 -0300
+From: David Bremner <david@tethera.net>
+To: Vladimir Marek <Vladimir.Marek@Oracle.COM>,
+	Tomi Ollila <tomi.ollila@iki.fi>
+Subject: Re: [PATCH] don't store temporary value returned from c_str()
+In-Reply-To: <20130427101134.GI10394@pub.cz.oracle.com>
+References: <1366405933-17223-1-git-send-email-Vladimir.Marek@oracle.com>
+	<m2sj2cjp2b.fsf@guru.guru-group.fi>
+	<20130427101134.GI10394@pub.cz.oracle.com>
+User-Agent: Notmuch/0.15.2+84~g12d5e4e (http://notmuchmail.org) Emacs/24.2.1
+	(x86_64-pc-linux-gnu)
+Date: Sat, 27 Apr 2013 08:53:33 -0300
+Message-ID: <8738ucw5oi.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-Spam_bar: -
+Cc: notmuch@notmuchmail.org, Vladimir Marek <vlmarek@volny.cz>
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sat, 27 Apr 2013 11:53:46 -0000
+
+Vladimir Marek <Vladimir.Marek@Oracle.COM> writes:
+
+>
+> const char*
+> string::c_str(void) {
+> 	char buf[100];
+>
+> 	strcpy (buf, this->internal_representation);
+> 	return buf;
+> }
+
+Isn't that undefined behavior, returning a pointer to a (non-static)
+local variable?
+
+d
-- 
2.26.2