From 10ae1ac92ced933c761c35e5888405bbe36ae9ac Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Mon, 10 Jun 2013 22:39:52 +2000 Subject: [PATCH] Re: [PATCH v4 0/5] emacs: show: lazy handling of hidden parts --- e0/075203e039863956dbc0264cf537a4d6bc6d4c | 99 +++++++++++++++++++++++ 1 file changed, 99 insertions(+) create mode 100644 e0/075203e039863956dbc0264cf537a4d6bc6d4c diff --git a/e0/075203e039863956dbc0264cf537a4d6bc6d4c b/e0/075203e039863956dbc0264cf537a4d6bc6d4c new file mode 100644 index 000000000..2649d8b97 --- /dev/null +++ b/e0/075203e039863956dbc0264cf537a4d6bc6d4c @@ -0,0 +1,99 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 15715431FAF + for ; Sun, 9 Jun 2013 19:40:05 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id bCBmSWFYAqqO for ; + Sun, 9 Jun 2013 19:39:57 -0700 (PDT) +Received: from dmz-mailsec-scanner-8.mit.edu (dmz-mailsec-scanner-8.mit.edu + [18.7.68.37]) + by olra.theworths.org (Postfix) with ESMTP id F286B431FAE + for ; Sun, 9 Jun 2013 19:39:56 -0700 (PDT) +X-AuditID: 12074425-b7f966d00000454c-0b-51b53c7ce65a +Received: from mailhub-auth-1.mit.edu ( [18.9.21.35]) + by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP + id 22.65.17740.C7C35B15; Sun, 9 Jun 2013 22:39:56 -0400 (EDT) +Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) + by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id r5A2dsFn028828; + Sun, 9 Jun 2013 22:39:55 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r5A2dqd8002769 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); + Sun, 9 Jun 2013 22:39:54 -0400 +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80) + (envelope-from ) + id 1Uls1Q-00069q-N2; Sun, 09 Jun 2013 22:39:52 -0400 +Date: Sun, 9 Jun 2013 22:39:52 -0400 +From: Austin Clements +To: Mark Walters +Subject: Re: [PATCH v4 0/5] emacs: show: lazy handling of hidden parts +Message-ID: <20130610023952.GC22196@mit.edu> +References: <1370074547-24677-1-git-send-email-markwalters1009@gmail.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <1370074547-24677-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFupmleLIzCtJLcpLzFFi42IR4hRV1q2x2RpocP6mmMWRPbPYLVbP5bG4 + fnMmswOzx85Zd9k9nq26xezR9GMxawBzFJdNSmpOZllqkb5dAlfGuo5JbAX3OCoWbrzN0sDY + xt7FyMEhIWAiseBqSRcjJ5ApJnHh3nq2LkYuDiGBfYwSnctAakCcDYwS015+gHJOMUnsXvMT + ylnNKPF3yX5WkH4WARWJic//M4LYbAL6EivWTgKLiwjoSNw+tIAdxGYWcJbY96mTDcQWFnCT + OL18OSvIGbxANatn14GEhQQ8JZqWngMr4RUQlDg58wkLRKuWxI1/L5lAypkFpCWW/+MACXMK + eEls+XkGrFwU6IIpJ7exTWAUmoWkexaS7lkI3QsYmVcxyqbkVunmJmbmFKcm6xYnJ+blpRbp + WujlZpbopaaUbmIEhTm7i+oOxgmHlA4xCnAwKvHwdvzYEijEmlhWXJl7iFGSg0lJlPe82dZA + Ib6k/JTKjMTijPii0pzU4kOMEhzMSiK8Py2BcrwpiZVVqUX5MClpDhYlcd4bKTf9hQTSE0tS + s1NTC1KLYLIyHBxKErznrYEaBYtS01Mr0jJzShDSTBycIMN5gIbfBanhLS5IzC3OTIfIn2JU + lBLnvQ+SEABJZJTmwfXC0tArRnGgV4R5X4FU8QBTGFz3K6DBTECDp6hvARlckoiQkmpgNG1a + YfAzXvbd6qR5m6Vc5H8tZ5qzhZn7k1juu/a0eY9+W0Uf3prpcr9YNPvKkvXPm2boy2Y07zgS + KOd6x3DpfJNtGareXmeDn6x7c3LNjLkBB3XOxhv1L9X+arp4l9GcYFb3u5Fzwp/caDl/+JXW + H8Gq5TzHtsu8utMkudIidlfeQ6sX79oeiSqxFGckGmoxFxUnAgD6wALXHgMAAA== +X-Mailman-Approved-At: Mon, 10 Jun 2013 01:19:52 -0700 +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 10 Jun 2013 02:40:05 -0000 + +Quoth Mark Walters on Jun 01 at 9:15 am: +> This is version 4 of this series. Version 3 is at +> id:1370024806-6616-1-git-send-email-markwalters1009@gmail.com +> +> Changes from version 3 are: fix the whitespace changes in patch 3/5, +> store both the start of the part and the start of the content in +> insert-bodypart (Austin's part handler series needs one and I need the +> other) and fixed the missing save-excursion in patch 4/5. +> +> Finally, there is one more substantial change: rebasing on to Austin's +> part handler (now in master). There was a little more to this than I +> expected so for anyone testing please use this version. + +This series LGTM except for one bug (also related to my new part +handling, sorry): after expanding a lazy part, the "." submap doesn't +work within that part because it doesn't get the :notmuch-part +property applied to it. I'm not sure what the best solution to this +is. Maybe applying :notmuch-part should be moved to +notmuch-show-create-part-overlays? + +Also, unrelated: with this series, do we wind up creating a second +overlay when a lazy part is shown? -- 2.26.2