From 108c2aaf7984081daa6aed6d3947c7c0952216c2 Mon Sep 17 00:00:00 2001 From: Abhijit Menon-Sen Date: Mon, 4 Aug 2008 17:08:27 +0530 Subject: [PATCH] Git.pm: localise $? in command_close_bidi_pipe() Git::DESTROY calls _close_cat_blob and _close_hash_and_insert_object, which in turn call command_close_bidi_pipe, which calls waitpid, which alters $?. If this happens during global destruction, it may alter the program's exit status unexpectedly. Making $? local to the function solves the problem. (The problem was discovered due to a failure of test #8 in t9106-git-svn-commit-diff-clobber.sh.) Signed-off-by: Abhijit Menon-Sen Signed-off-by: Junio C Hamano --- perl/Git.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/perl/Git.pm b/perl/Git.pm index 087d3d0e8..faaa19f62 100644 --- a/perl/Git.pm +++ b/perl/Git.pm @@ -417,6 +417,7 @@ have more complicated structure. =cut sub command_close_bidi_pipe { + local $?; my ($pid, $in, $out, $ctx) = @_; foreach my $fh ($in, $out) { unless (close $fh) { -- 2.26.2